Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing old unused RQ_DEFAULT_TIMEOUT variable #161

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

nniehoff
Copy link
Contributor

This PR Removes references to the old RQ_DEFAULT_TIMEOUT which is no longer being used.

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

I notice that the RQ_QUEUES section in docs/configuration/required-settings.md does not currently describe the purpose of the DEFAULT_TIMEOUT parameter - perhaps some of the wording that you've correctly removed from optional-settings.md should be added there?

@jathanism
Copy link
Contributor

jathanism commented Mar 17, 2021

@nniehoff Glenn is referring to this section, https://nautobot.readthedocs.io/en/latest/configuration/required-settings/#rq_queues

If you wouldn't mind moving the mention of DEFAULT_TIMEOUT there using the text you ripped out of the optional-settings doc? Thank you!

@nniehoff
Copy link
Contributor Author

Good catch, updated

Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - thank you!

@jathanism jathanism merged commit 147c297 into nautobot:develop Mar 18, 2021
@nniehoff nniehoff deleted the nn_remove_old_rq_timeout branch January 7, 2022 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants