Physical Interfaces Parenting Virtual Interfaces #1651

timizuoebideri1 · 2022-04-18T13:10:24Z

Closes: #1455

What's Changed

Prototype physical Interfaces Parenting Virtual Interfaces by porting over NetBox implementation

Added parent_interface and bridge fields to Interface and VMInterface model
Created a filter_device_common_vc_id method in InterfaceFilterSet and added a new field device_with_common_vc which implements filter_device_common_vc_id as its method:
- filter_device_common_vc_id returns interfaces with same device or virtual_chassis unlike filter_device_id which returns only interfaces with same device and only return interfaces with same vc if device.virtual_chassis is master.
- Replace device_id query params with device_with_common_vc for parent_interface, bridge, and lag
- Dynamically filter parent_interface, bridge, lag using "device_with_common_vc": "$device" as a query params on InterfaceCreateForm.
Closes #1519: Enable parent assignment for interfaces netbox-community/netbox#5930
Closes #6346: Bridge group support netbox-community/netbox#7622
netbox-community/netbox@61d2158

TODO

Explanation of Change(s)
Attached Screenshots, Payload Example
Unit, Integration Tests
Documentation Updates (when adding/changing features)
Example Plugin Updates (when adding/changing features)
Outline Remaining Work, Constraints from Design

- rename @Property parent to parent_object

- Replace parent with parent_object in relevant locations

- Apply InterfaceSerializerVersion13 to InterfaceViewSet

- Add parent field to VMInterface, VMInterfaceForm, VMInterfaceFilterSet, VMInterfaceTable - Modify vm templates accordingly

- Modify TestCases to account for bridge - Modify interface.html add bridge to table

glennmatthews

Just a few brief observations, since I know this is still a draft. :-)

nautobot/dcim/api/serializers.py

nautobot/dcim/migrations/0011_interface_bridge.py

nautobot/dcim/tests/test_views.py

nautobot/dcim/api/serializers.py

nautobot/dcim/forms.py

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

nautobot/virtualization/api/nested_serializers.py

…ified device

# Conflicts: # nautobot/dcim/api/views.py # nautobot/dcim/models/device_components.py # nautobot/dcim/tests/test_api.py # nautobot/dcim/tests/test_forms.py # nautobot/ipam/filters.py # nautobot/ipam/tests/test_filters.py # nautobot/virtualization/api/views.py # nautobot/virtualization/models.py # nautobot/virtualization/tests/test_views.py

…ield

nautobot/dcim/api/views.py

nautobot/dcim/forms.py

nautobot/dcim/models/device_components.py

nautobot/dcim/tests/test_api.py

nautobot/dcim/tests/test_forms.py

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

…e-parenting' into timizuo-GH1455-pyysical-interface-parenting

timizuoebideri1 added 13 commits April 18, 2022 09:12

Add parent field to Interface

61ae291

- rename @Property parent to parent_object

Add parent field to devices Filter, Forms and Table

bb73426

- Replace parent with parent_object in relevant locations

Replace parent with parent_object in relevant files in templates

31ae506

Create InterfaceSerializerVersion13 serializer

c159724

- Apply InterfaceSerializerVersion13 to InterfaceViewSet

Add interface parent and lag filter test case

24ec88a

Extend parent to VM

91e4694

- Add parent field to VMInterface, VMInterfaceForm, VMInterfaceFilterSet, VMInterfaceTable - Modify vm templates accordingly

Implement VMInterfaceSerializer for api_version 1.3

83d8594

Add VMinterface migration

60a95d5

Add bridge to field to the dcim.Interfac model

f12a0ae

Modify relevant testcase

e610716

Add bridge to relevant files

dadee85

- Modify TestCases to account for bridge - Modify interface.html add bridge to table

Account for bridge in versioned interface and vminterface serializers

1f8a9b9

black format

df09e0c

timizuoebideri1 marked this pull request as draft April 18, 2022 13:11

glennmatthews reviewed Apr 18, 2022

View reviewed changes

nautobot/dcim/api/serializers.py Outdated Show resolved Hide resolved

nautobot/dcim/migrations/0011_interface_bridge.py Outdated Show resolved Hide resolved

nautobot/dcim/tests/test_views.py Outdated Show resolved Hide resolved

timizuoebideri1 linked an issue Apr 20, 2022 that may be closed by this pull request

Implement Physical Interfaces Parenting Virtual Interfaces #1455

Closed

timizuoebideri1 force-pushed the timizuo-GH1455-pyysical-interface-parenting branch from a6f9cc2 to 465aded Compare April 21, 2022 20:01

timizuoebideri1 marked this pull request as ready for review April 21, 2022 20:03

timizuoebideri1 force-pushed the timizuo-GH1455-pyysical-interface-parenting branch from 465aded to 8f87e64 Compare April 21, 2022 20:05

fix dcim.tests.test_view error

4860158

timizuoebideri1 force-pushed the timizuo-GH1455-pyysical-interface-parenting branch from 8f87e64 to 4860158 Compare April 21, 2022 20:33

glennmatthews reviewed Apr 26, 2022

View reviewed changes

nautobot/dcim/api/serializers.py Outdated Show resolved Hide resolved

nautobot/dcim/forms.py Outdated Show resolved Hide resolved

nautobot/dcim/forms.py Show resolved Hide resolved

nautobot/dcim/forms.py Outdated Show resolved Hide resolved

nautobot/dcim/forms.py Show resolved Hide resolved

timizuoebideri1 and others added 4 commits April 26, 2022 21:48

Update nautobot/dcim/forms.py

2d56c99

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

group lag together with parent and bridge

826a0b7

Remove InterfaceCSV Form __init__

3af1dd6

add bridge to InterfaceTypeChoices

dd570ca

bryanculver force-pushed the timizuo-GH1455-pyysical-interface-parenting branch from 924b48f to 4860158 Compare April 27, 2022 18:19

bryanculver added 2 commits April 27, 2022 14:37

Fix serializer

41bade0

Make black happy

74f686d

bryanculver reviewed Apr 27, 2022

View reviewed changes

nautobot/virtualization/api/nested_serializers.py Outdated Show resolved Hide resolved

timizuoebideri1 added 5 commits May 20, 2022 14:44

add interface API test case testing for vc or device

1b11a0d

add available_on_device to vlanfilter set to filter for vlans ti spec…

bdff51e

…ified device

merge next into dev

c06929f

add merge

69be442

bryanculver linked an issue May 23, 2022 that may be closed by this pull request

Allow "Physical" interfaces to be parents of "Virtual" interfaces #929

Closed

1 task

timizuoebideri1 added 4 commits May 24, 2022 10:00

reorder new dcim and virtualization imports

30b7618

add label to available_on_device

2898ffd

use UUIDFilter instead of ModelChoiceFilter for available_on_device f…

5566dc4

…ield

add help text

dfba66a

timizuoebideri1 requested review from bryanculver, jathanism and glennmatthews May 24, 2022 23:47

rerun flake8

d52a2b4

glennmatthews reviewed May 26, 2022

View reviewed changes

timizuoebideri1 and others added 8 commits May 26, 2022 18:35

Update nautobot/dcim/tests/test_api.py

f16e6de

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

Update nautobot/dcim/tests/test_api.py

1d2c08e

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

Update nautobot/dcim/tests/test_forms.py

bb966de

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

Update nautobot/dcim/tests/test_forms.py

841c564

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

Update nautobot/dcim/tests/test_api.py

255a5ab

Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>

Merge branch 'next' into timizuo-GH1455-pyysical-interface-parenting

e1e5a4f

exclude non-physical interface from parent filter in InterfaceCSVForm

236e873

Merge remote-tracking branch 'origin/timizuo-GH1455-pyysical-interfac…

dbca30d

…e-parenting' into timizuo-GH1455-pyysical-interface-parenting

timizuoebideri1 requested a review from glennmatthews May 26, 2022 18:32

glennmatthews approved these changes May 26, 2022

View reviewed changes

glennmatthews merged commit 80cf286 into next May 31, 2022

This was referenced May 31, 2022

1.4: Interface API version 1.4 is missing parent_interface and bridge fields #1831

Closed

Implement Physical Interfaces Parenting Virtual Interfaces #1455

Closed

bryanculver mentioned this pull request Jun 14, 2022

Allow "Physical" interfaces to be parents of "Virtual" interfaces #929

Closed

1 task

timizuoebideri1 deleted the timizuo-GH1455-pyysical-interface-parenting branch June 22, 2022 09:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Physical Interfaces Parenting Virtual Interfaces #1651

Physical Interfaces Parenting Virtual Interfaces #1651

timizuoebideri1 commented Apr 18, 2022 •

edited

Loading

glennmatthews left a comment

Physical Interfaces Parenting Virtual Interfaces #1651

Physical Interfaces Parenting Virtual Interfaces #1651

Conversation

timizuoebideri1 commented Apr 18, 2022 • edited Loading

Closes: #1455

What's Changed

TODO

glennmatthews left a comment

Choose a reason for hiding this comment

timizuoebideri1 commented Apr 18, 2022 •

edited

Loading