Use static templatetag for drf-spectacular-sidecar files #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathanism
approved these changes
Apr 26, 2022
bryanculver
approved these changes
Apr 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #N/A
What's Changed
Work around for tfranzel/drf-spectacular#718. Since we already have a custom page template for the Swagger UI view, and we know that in Nautobot's case we always are using drf-spectacular-sidecar, we can directly use the
statictemplatetag, bypassing drf-spectacular's currently more-flexible (since it can use CDNs as well as drf-spectacular-sidecar) but less-robust (because it doesn't handle STATICFILES_STORAGE yet) calculation of the paths to the relevant static files.