Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Secrets Docs Advisory #1751

Merged
merged 2 commits into from
May 5, 2022
Merged

Update Secrets Docs Advisory #1751

merged 2 commits into from
May 5, 2022

Conversation

bryanculver
Copy link
Member

Closes: #DNE

What's Changed

Add message to Secrets doc on additional reasons to limit secret modification privileges.

TODO

  • Explanation of Change(s)
  • [NA] Attached Screenshots, Payload Example
  • [NA] Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • [NA] Example Plugin Updates (when adding/changing features)
  • [NA] Outline Remaining Work, Constraints from Design

@bryanculver bryanculver changed the title Update secrets docs to spell out need for object permissions on secrets Update Secrets Docs Advisory May 4, 2022
@bryanculver @glennmatthews
Update nautobot/docs/core-functionality/secrets.md
62f1a88 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@itdependsnetworks
Copy link
Contributor

I think it is worth noting that the same is true with any secrets system.

@bryanculver bryanculver merged commit c84c249 into develop May 5, 2022
bryanculver added a commit that referenced this pull request May 5, 2022
@bryanculver
Add release-note for #1751
67e968f
@bryanculver bryanculver added this to the v1.3.4 milestone May 10, 2022
@bryanculver bryanculver mentioned this pull request May 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryanculver @itdependsnetworks @glennmatthews