Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Plugin Ability to Override Views (Core and Plugin) #1957

Merged
merged 36 commits into from Jul 12, 2022
Merged

Add Plugin Ability to Override Views (Core and Plugin) #1957

merged 36 commits into from Jul 12, 2022

Conversation

briddo
Copy link
Contributor

@briddo briddo commented Jun 24, 2022 •
edited

Closes: #1466

Todo:

  • Docs

glennmatthews
glennmatthews reviewed Jun 24, 2022
View reviewed changes
examples/example_plugin/example_plugin/urls.py Show resolved Hide resolved
examples/example_plugin/example_plugin/views.py Outdated Show resolved Hide resolved
nautobot/extras/plugins/__init__.py Outdated Show resolved Hide resolved
nautobot/extras/plugins/__init__.py Outdated Show resolved Hide resolved
nautobot/extras/plugins/__init__.py Outdated Show resolved Hide resolved
nautobot/extras/plugins/__init__.py Outdated Show resolved Hide resolved
nautobot/extras/plugins/__init__.py Outdated Show resolved Hide resolved
briddo and others added 6 commits June 24, 2022 17:43
@briddo @glennmatthews
Update examples/example_plugin/example_plugin/views.py
1b45a90 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@briddo @glennmatthews
Update nautobot/extras/plugins/__init__.py
bfff69c 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@briddo @glennmatthews
Update nautobot/extras/plugins/__init__.py
46ce562 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@briddo @glennmatthews
Update nautobot/extras/plugins/__init__.py
1011ad4 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@briddo
Clean up and PR suggestions
493ef1e
@briddo
black
4f2f079
@bryanculver bryanculver added the type: feature Introduction of new or enhanced functionality to the application label Jun 24, 2022
@bryanculver bryanculver linked an issue Jun 27, 2022 that may be closed by this pull request
Allow plugins to replace core views #1466
Closed
12 tasks
bryanculver
bryanculver reviewed Jul 6, 2022
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
examples/plugin_with_view_override/plugin_with_view_override/__init__.py Outdated Show resolved Hide resolved
nautobot/core/tests/nautobot_config.py Outdated Show resolved Hide resolved
examples/plugin_with_view_override/pyproject.toml Outdated Show resolved Hide resolved
poetry.lock Outdated Show resolved Hide resolved
@bryanculver bryanculver changed the title Allow plugin to override views Add Plugin Ability to Override Views (Core and Plugin) Jul 7, 2022
briddo and others added 6 commits July 8, 2022 22:31
@briddo @bryanculver
Update nautobot/extras/plugins/__init__.py
7450a32 
Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
@briddo @bryanculver
Update examples/plugin_with_view_override/pyproject.toml
0cfb520 
Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
@briddo @bryanculver
Update examples/plugin_with_view_override/plugin_with_view_override/_…
d39281b 
…_init__.py

Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
@briddo @bryanculver
Update nautobot/core/tests/nautobot_config.py
55ca939 
Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
@briddo @bryanculver
Update pyproject.toml
266b6d7 
Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
@briddo
PR suggestions
92862ce
@briddo briddo requested a review from bryanculver July 8, 2022 21:38
bryanculver
bryanculver approved these changes Jul 12, 2022
View reviewed changes
Copy link
Member

@bryanculver bryanculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Waiting for CI then will merge.

@bryanculver bryanculver merged commit 7ee6c00 into next Jul 12, 2022
@bryanculver bryanculver mentioned this pull request Jul 12, 2022
Closed
12 tasks
@bryanculver bryanculver deleted the dpb-issue-1466 branch July 27, 2022 21:08
@bryanculver bryanculver mentioned this pull request Aug 10, 2023
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews left review comments

@bryanculver bryanculver bryanculver approved these changes

Assignees
No one assigned
Labels
type: feature Introduction of new or enhanced functionality to the application
Projects
No open projects
Nautobot Core ⚙️
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow plugins to replace core views
3 participants
@briddo @bryanculver @glennmatthews