Add custom job intervals #2084
Merged
Add custom job intervals #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 20, 2022 14:41
jathanism
suggested changes
Jul 21, 2022
yoonthegoon
commented
Jul 22, 2022
jtdub
requested changes
Jul 22, 2022
jathanism
suggested changes
Jul 25, 2022
added 11 commits
July 25, 2022 18:01
bryanculver
reviewed
Jul 28, 2022
Comment on lines
860
to
865
| return schedules.crontab(minute=t.minute, hour=t.hour) | ||
| elif self.interval == JobExecutionType.TYPE_WEEKLY: | ||
| return schedules.crontab(minute=t.minute, hour=t.hour, day_of_week=t.weekday()) | ||
| elif self.interval == JobExecutionType.TYPE_CUSTOM: | ||
| return self.get_crontab(self.crontab) | ||
| raise ValueError(f"I do not know to convert {self.interval} to a Cronjob!") |
There was a problem hiding this comment.
I think it would be good to add a housekeeping item to stash the crontab onto self.crontab in all cases. Could clean up a lot of these methods.
jathanism
suggested changes
Jul 29, 2022
jathanism
approved these changes
Jul 29, 2022
|
thank you for the feedback. i learned a lot |
smk4664
added a commit
to smk4664/nautobot
that referenced
this pull request
Jul 29, 2022
* next: (26 commits) Include relationships and associations on object REST APIs (nautobot#2092) Add release-note for nautobot#2116 Update Releases Batched for Next (next) (nautobot#2116) Re-ordered migrations Add release-note for nautobot#1226, nautobot#1739, nautobot#2115 Add custom job intervals (nautobot#2084) Implement Notes Model (nautobot#1984) Update Lock-file Patch Releases for Develop (nautobot#2115) update paginator to enforce max_page_size setting in web ui views (nautobot#2112) Add missing location status migration (nautobot#2100) update release-notes for issue nautobot#2060 added peer_id filter for relationship associations (nautobot#2113) Add release-note for nautobot#2025 Cleanup group names, manual approval for flake8 (nautobot#2025) updated documentations for nautobot#2109 and nautobot#2111 fixed one to many relationship source filter and apply AND operator between filters (nautobot#2111) Version bump to v1.3.10-beta.1, seeded next version in docs. Add release-note for nautobot#860, nautobot#1694, nautobot#2081. Update release date, version. Fix nautobot#2077 - handle case on object detail views where a relationship involves a non-installed model (nautobot#2078) Fix error raised if status connected not found when creating a cable (nautobot#2089) ... # Conflicts: # nautobot/circuits/api/serializers.py # nautobot/core/api/serializers.py # nautobot/dcim/api/serializers.py # nautobot/docs/development/best-practices.md # nautobot/docs/development/style-guide.md # nautobot/docs/release-notes/version-1.4.md # nautobot/extras/api/nested_serializers.py # nautobot/extras/api/relationships.py # nautobot/extras/api/serializers.py # nautobot/extras/tests/integration/test_notes.py # nautobot/extras/tests/test_api.py # nautobot/utilities/testing/api.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1226
What's Changed
Adds custom cron style interval for running jobs.
TODO