Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flaky integration test for cable interface selection. #2119

Merged
merged 2 commits into from Jul 30, 2022
Merged

Fix flaky integration test for cable interface selection. #2119

merged 2 commits into from Jul 30, 2022

Conversation

bryanculver
Copy link
Member

Closes: Flaky Integration Test

What's Changed

  • Find elements by their IDs
  • Don't use keyboard to navigate Select2 dropdown
  • Slightly increase sleep just in case (no simple wait to wait on change)

TODO

  • Explanation of Change(s)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@bryanculver @glennmatthews
Apply suggestions from code review
54b8fb1 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@bryanculver bryanculver merged commit 9f49807 into develop Jul 30, 2022
bryanculver added a commit that referenced this pull request Jul 30, 2022
@bryanculver
Add release-note for #2119
6d32d9b
smk4664 added a commit to smk4664/nautobot that referenced this pull request Aug 1, 2022
@smk4664
Merge branch 'next' into NotesAPI
9cb5b49 
* next:
  Add release-note for nautobot#2119
  Fix flaky integration test for cable interface selection. (nautobot#2119)
  add release note for nautobot#2103
  Add Job Hooks (nautobot#2103)
  Added release-notes for nautobot#1614, nautobot#2069 (Dynamic Groups of Dynamic Groups)
  Dynamic Groups UX improvements (nautobot#2079)
  Revert "Fix flaky integration test for cable interface selection."
  Fix flaky integration test for cable interface selection.
@bryanculver bryanculver deleted the bsc-fix-flaky-integration-test branch August 17, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bryanculver @glennmatthews