Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix job.request removed from job instance in v1.4.0b1 #2199

Merged
merged 4 commits into from Aug 12, 2022
Merged

Fix job.request removed from job instance in v1.4.0b1 #2199

merged 4 commits into from Aug 12, 2022

Conversation

gsnider2195
Copy link
Contributor

@gsnider2195 gsnider2195 commented Aug 12, 2022 •
edited

Closes: #2192

What's Changed

Job.request was mistakenly removed from the job instance in #2035. Re-add to job.request and add test case to test for this functionality.

TODO

  • Explanation of Change(s)
  • n/a Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • n/a Documentation Updates (when adding/changing features)
  • n/a Example Plugin Updates (when adding/changing features)
  • n/a Outline Remaining Work, Constraints from Design

bryanculver
bryanculver approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@bryanculver bryanculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for integration test to pass

@gsnider2195 gsnider2195 merged commit 7691286 into develop Aug 12, 2022
@gsnider2195 gsnider2195 deleted the gas-2192-jobs-request branch August 12, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanculver bryanculver bryanculver approved these changes

@jathanism jathanism jathanism approved these changes

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[1.4] Job.run - self.request is None
4 participants
@gsnider2195 @bryanculver @jathanism @glennmatthews