Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andy/race next available #245

Merged
merged 10 commits into from
Apr 14, 2021
Merged

Andy/race next available #245

merged 10 commits into from
Apr 14, 2021

Conversation

andy-wm-arthur
Copy link
Contributor

Demonstrates race condition in next-available-prefix API

@andy-wm-arthur andy-wm-arthur marked this pull request as ready for review April 6, 2021 17:20
glennmatthews
glennmatthews reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove django-pglocks from the project dependencies as part of this PR, correct?

nautobot/core/templates/nautobot_config.py.j2 Show resolved Hide resolved
jathanism
jathanism suggested changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll still need the config template and docs to be updated for the new CACHES setting. I'm happy to help with those. I suggested a couple minor tweaks in the interim.

pyproject.toml Show resolved Hide resolved
nautobot/ipam/api/views.py Outdated Show resolved Hide resolved
andy-wm-arthur and others added 3 commits April 7, 2021 09:54
@jathanism jathanism added this to the v1.0.0 milestone Apr 9, 2021
@jathanism jathanism self-assigned this Apr 13, 2021
@jathanism jathanism added this to In progress in Release v1.0.0 via automation Apr 13, 2021
@jathanism jathanism mentioned this pull request Apr 14, 2021
Merged
Release v1.0.0 automation moved this from In progress to Reviewer approved Apr 14, 2021
@jathanism jathanism merged commit 3ab32b6 into nautobot:develop Apr 14, 2021
Release v1.0.0 automation moved this from Reviewer approved to Done Apr 14, 2021
@jathanism jathanism mentioned this pull request Apr 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews left review comments

@jathanism jathanism jathanism approved these changes

Assignees

@jathanism jathanism

Labels
None yet
Projects
No open projects
Release v1.0.0
  
Done
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andy-wm-arthur @jathanism @glennmatthews