Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Anonymous Status Checks #298

Closed
wants to merge 1 commit into from

Conversation

nniehoff
Copy link
Contributor

Fixes: 297

This change enables anonymous access of the /api/status view, if the request is authenticated the response will contain version information as it does currently. However, if the request is anonymous an empty json response is returned to avoid exposing potentially security-sensitive version information. Another approach would be to use something like django-health-check.

@glennmatthews
Copy link
Contributor

Just checking, since you also opened #297 - but does this actually meet the requirements you identified in that issue? That wants the API to include information about whether the DB is working properly, for example.

I know there's a need for some sort of unauthenticated health-check API endpoint, and I understand if this is a good starting point for such a thing, but wondering if we should leave #297 open even after this PR is merged, as a feature request for a more comprehensive endpoint such as using django-health-check.

@nniehoff
Copy link
Contributor Author

Just checking, since you also opened #297 - but does this actually meet the requirements you identified in that issue? That wants the API to include information about whether the DB is working properly, for example.

I was told it did, however after some testing, I can confirm it does not, I'm closing this PR.

@nniehoff nniehoff closed this Apr 13, 2021
@nniehoff nniehoff deleted the nn_healthcheck branch April 13, 2021 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants