Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Format csv test expected data using csv_format #3420

Merged
merged 2 commits into from Mar 17, 2023
Merged

fix: Format csv test expected data using csv_format #3420

merged 2 commits into from Mar 17, 2023

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Mar 14, 2023

Closes: #3419

What's Changed

Fixed test_queryset_to_csv to use format_csv on data fetched from the model.

@snaselj snaselj force-pushed the u/snaselj-3419-fix-csv-tests branch from b88c1c8 to ff3edc7 Compare March 15, 2023 12:42
glennmatthews
glennmatthews approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand what this is doing, it looks reasonable to me. Thanks! :-)

@snaselj snaselj marked this pull request as ready for review March 15, 2023 13:23
@bryanculver bryanculver merged commit a9faf3f into develop Mar 17, 2023
@bryanculver bryanculver deleted the u/snaselj-3419-fix-csv-tests branch March 17, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Date formatting bug in CSV tests
3 participants
@snaselj @glennmatthews @bryanculver