Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI 2.0 Review #3556

Merged
merged 132 commits into from
Apr 25, 2023
Merged

UI 2.0 Review #3556

merged 132 commits into from
Apr 25, 2023

Conversation

bryanculver
Copy link
Member

Not intended for merging at this time but GitHub's diff review tools are pretty stellar since we can add comments.

Using this to help merge next into next-ui-2.0, then hopefully we can make it easier to ship an alpha of the UI.

timizuoebideri1 and others added 24 commits March 7, 2023 23:08
* Don't copy node_modules and UI build when rebuilding docker image

* Capture npm output and print it in case of failures

* Create docker volume for node_modules, change container startup, update docs
Initial removal of react-bootstrap and addition of nautobot-ui
* Add test for component common

* common test case

* Done testing core

* Add test for BSTableItem Component

* Add partial views test

* Add test for views

* add doc

* run ui unittest

* Apply suggestions from code review

Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com>

* fix markdown

* update ReadMe

* Update nautobot/ui/README.md

Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>

* Merge conflicts

* Update README.md

---------

Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com>
Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com>
Co-authored-by: Bryan Culver <bryan.culver@networktocode.com>
* Provide a way to refresh CSRF without shortcutting CSRF protections

* Session endpoint

* Stashing to switch between computers

* more stashing

* yeeet

* This is going to be a lot

* Updates

* Updates from feedback

* Black & flake8

* Fix indention

* Remove top-level package lock

* Revert bad merge
* Cleanup Router Links

* Move font to built-in instead of served via Google Fonts.

* Remove unneccessary import
Fix Jest testing

Remove should be ignored paths file as this is autogenerated

Scope creep avoid get tests passing so we can demonstrate it's working.

Prettier...

Add base paths for testing

No cached example, just copy the template in CI

Mock would prefer a file exists for app_imports.js
* Add New UI Toggle

* Add changelog fragment.

* Prettier
* Fix corrupted package-lock.json

* Add changelog fragment.

* Remove duplicate package for nautbot-ui
* Get tests passing for UI 2.0

* Add changelog fragment.

* Updates from feedback

* Exception handling
* [UI 2.0] Implement GenericView component

* [UI 2.0] Add missing objectData prop to GenericView in ObjectRetrieve view

* [UI 2.0] Remove Current route is ... debug message

* Move popover to it's own component.

---------

Co-authored-by: Bryan Culver <bryan.culver@networktocode.com>
Co-authored-by: Bryan Culver <me@bryanculver.com>
@bryanculver bryanculver marked this pull request as ready for review April 25, 2023 11:06
@bryanculver bryanculver changed the title [REVIEW ONLY] UI 2.0 Review UI 2.0 Review Apr 25, 2023
@bryanculver bryanculver merged commit 8a331fe into next Apr 25, 2023
19 checks passed
@bryanculver bryanculver deleted the next-ui-2.0 branch April 25, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants