-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI 2.0 Review #3556
Merged
Merged
UI 2.0 Review #3556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7bccab7.
* Don't copy node_modules and UI build when rebuilding docker image * Capture npm output and print it in case of failures * Create docker volume for node_modules, change container startup, update docs
Initial removal of react-bootstrap and addition of nautobot-ui
* Add test for component common * common test case * Done testing core * Add test for BSTableItem Component * Add partial views test * Add test for views * add doc * run ui unittest * Apply suggestions from code review Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com> * fix markdown * update ReadMe * Update nautobot/ui/README.md Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com> * Merge conflicts * Update README.md --------- Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com> Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com> Co-authored-by: Bryan Culver <bryan.culver@networktocode.com>
* Provide a way to refresh CSRF without shortcutting CSRF protections * Session endpoint * Stashing to switch between computers * more stashing * yeeet * This is going to be a lot * Updates * Updates from feedback * Black & flake8 * Fix indention * Remove top-level package lock * Revert bad merge
* Cleanup Router Links * Move font to built-in instead of served via Google Fonts. * Remove unneccessary import
Fix Jest testing Remove should be ignored paths file as this is autogenerated Scope creep avoid get tests passing so we can demonstrate it's working. Prettier... Add base paths for testing No cached example, just copy the template in CI Mock would prefer a file exists for app_imports.js
* Add New UI Toggle * Add changelog fragment. * Prettier
* Fix corrupted package-lock.json * Add changelog fragment. * Remove duplicate package for nautbot-ui
* Get tests passing for UI 2.0 * Add changelog fragment. * Updates from feedback * Exception handling
Merge `next` into `next-ui-2.0`
* [UI 2.0] Implement GenericView component * [UI 2.0] Add missing objectData prop to GenericView in ObjectRetrieve view * [UI 2.0] Remove Current route is ... debug message * Move popover to it's own component. --------- Co-authored-by: Bryan Culver <bryan.culver@networktocode.com> Co-authored-by: Bryan Culver <me@bryanculver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not intended for merging at this time but GitHub's diff review tools are pretty stellar since we can add comments.
Using this to help merge
next
intonext-ui-2.0
, then hopefully we can make it easier to ship an alpha of the UI.