Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed loading widget in new UI #3743

Merged
merged 7 commits into from
May 26, 2023
Merged

Conversation

DistantVoyager
Copy link
Contributor

@DistantVoyager DistantVoyager commented May 12, 2023

Closes: #3742

What's Changed

  • Centered the LoadingWidget component in UI.
  • Lightened the color of the LoadingWidget text to gray-3.
  • Also updated the endColor of the skeleton loading animation (when tables load) to a lighter gray so it's easier on the eyes.

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)

@DistantVoyager DistantVoyager requested a review from a team May 12, 2023 18:34
@DistantVoyager DistantVoyager linked an issue May 12, 2023 that may be closed by this pull request
1 task
@glennmatthews
Copy link
Contributor

Thanks for the pull request! I like the idea, but we may not be able to go in this direction as-is due to the need to support custom branding of an installed Nautobot instance.

@bryanculver
Copy link
Member

Thanks for the idea @DistantVoyager!

@DistantVoyager
Copy link
Contributor Author

@bryanculver @glennmatthews - Of course! This PR also correctly centers the LoadingWidget component and lightens the SkeletonText & loading widget text colors - do you guys want those changes? (if so I can create a new PR with just those minor fixes)

Currently:
image

Correctly Centered:
image

@bryanculver
Copy link
Member

Sure! you can update and re-open.

@DistantVoyager DistantVoyager changed the title Modified loading widget in new UI Fixed loading widget in new UI May 23, 2023
@DistantVoyager DistantVoyager self-assigned this May 23, 2023
Copy link
Contributor

@HanlinMiao HanlinMiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM!

@glennmatthews glennmatthews merged commit f5c4e65 into next May 26, 2023
21 checks passed
@glennmatthews glennmatthews deleted the steven-new-loading-widget branch May 26, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance the loading icon within new UI
4 participants