-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Markdown custom field type #4007
Conversation
- multi-line text entry based on CommentField using SmallTextarea widget
Definitely open for feedback!
|
At @lampwins' feedback, this can be included as a part of 1.6. |
PR might look ugly until #4020 goes in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks both straightforward and useful - my favorite type of PR! :-)
Reorder added imports alphabetically
Oh oops, looks like our CI isn't checking for it in |
Thanks Glenn, you previously reminded me on another pull request on the changelog fragment. I'll try and get that jammed in my brain! Fragment |
Closes: #4006
What's Changed
NOTE
render_markdown()
to test for script injection similar to custom_fields.py#L588 since that doesnt sanitize/check thefield.label
data?TODO
SCREENSHOTS