Ensured that job_class values ScheduledJob instances are transferred to task during v2 migration. #4682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to task during v2 migration.
glennmatthews
approved these changes
Oct 19, 2023
glennmatthews
added a commit
that referenced
this pull request
Oct 24, 2023
* Fix post upgrade bug * fix rackrole also * add unittest * add unittest * Apply suggestions from code review * Seed version 2.0.3b1 * fix test * Update 4604.fixed Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * Handle Docs Redirections (#4669) * Add redirects for simple file renames. * Add non-simple redirects for squashed/refactored pages. * Deleted files pass 2 * Add changelog fragment * Apply suggestions from code review Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * Alpha sort redirects --------- Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * Added validation step to handle invalid/legacy filters from v1.x in DynamicGroup form validation and silently ignore invalid filter data in DynamicGroupDetailView. (#4653) * added a data migration to cleanup v1.x tag filter data in v2.x DynamicGroup instances * Added validation step to handle invalid/legacy filters from v1.x in DynamicGroup form validation. * pylint * address PR feedback * modify log message * Fixed error `'IPAddressBulkAddForm' has no field named 'parent'` when bulk creating IPs via UI. (#4644) * Fix bug * Add unittest * Update nautobot/ipam/tests/test_views.py Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com> * resolve PR feedback * Add check for missing CIRD in form pattern * Fix typo and replace model_form.vrf with model_form.dns_name * fix flake8 * fix test failures * fix test failures * Add TODO * fix failing test --------- Co-authored-by: Timizuo <ebideritimizuo@gmail.com> Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com> Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * Disable New UI by default (#4661) Co-authored-by: Timizuo <ebideritimizuo@gmail.com> * Ensured that job_class values ScheduledJob instances are transferred to task during v2 migration. (#4682) * Bump urllib3 from 2.0.6 to 2.0.7 (#4671) * Bump urllib3 from 2.0.6 to 2.0.7 Bumps [urllib3](https://github.com/urllib3/urllib3) from 2.0.6 to 2.0.7. - [Release notes](https://github.com/urllib3/urllib3/releases) - [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst) - [Commits](urllib3/urllib3@2.0.6...2.0.7) --- updated-dependencies: - dependency-name: urllib3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Change fragment --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * Bump version * Fix `Meta` inheritance in nested serializer classes (#4692) * Add test coverage * Fix issue * Change fragment * Add more change fragments * Refine test implementation * Add reference to GHSA * Add admonition about use of fields = __all__ on serializers * Add PR number --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Timizuo <ebideritimizuo@gmail.com> Co-authored-by: Timizuo <94907097+timizuoebideri1@users.noreply.github.com> Co-authored-by: Bryan Culver <31187+bryanculver@users.noreply.github.com> Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com> Co-authored-by: Gary Snider <75227981+gsnider2195@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4676
What's Changed
TODO