Added support for request profiling via django-silk #5169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
|
We want to add a setting to toggle this feature (or document the existing setting). Also backport to LTM. |
12 tasks
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
glennmatthews
approved these changes
Feb 1, 2024
gsnider2195
reviewed
Feb 1, 2024
gsnider2195
reviewed
Feb 1, 2024
gsnider2195
reviewed
Feb 1, 2024
gsnider2195
reviewed
Feb 1, 2024
gsnider2195
approved these changes
Feb 1, 2024
… into u/lampwins-django-silk
lampwins
added a commit
that referenced
this pull request
Feb 2, 2024
* added support for django-silk * changelog and permissions * disable lambda warning * disable lambda warning * disable lambda warning * disable lambda warning * linting wins, no more lambda * Apply suggestions from code review Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * Update nautobot/users/urls.py Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * added ALLOW_REQUEST_PROFILING setting and access tests * Update nautobot/users/tests/test_views.py Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * pr updates * pr updates * fix tests * add link to silk when superuser --------- Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com>
lampwins
added a commit
that referenced
this pull request
Feb 2, 2024
* Added support for request profiling via django-silk (#5169) * added support for django-silk * changelog and permissions * disable lambda warning * disable lambda warning * disable lambda warning * disable lambda warning * linting wins, no more lambda * Apply suggestions from code review Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * Update nautobot/users/urls.py Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * added ALLOW_REQUEST_PROFILING setting and access tests * Update nautobot/users/tests/test_views.py Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> * pr updates * pr updates * fix tests * add link to silk when superuser --------- Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com> * added note about files --------- Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com> Co-authored-by: Hanlin Miao <46973263+HanlinMiao@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changed
This adds support for user session profiling via django-silk. This allows a user to enable a setting in their user profile which persists until they log out or disable the setting. Django silk will then log all subsequent requests for that user's session. Administrators can access the logs in the silk UI.
Screenshots
TODO