Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: rearrange job list table row contents #5200

Conversation

norbert-mieczkowski-codilime
Copy link
Collaborator

Closes #5126

What's Changed

  • Decrease job group accordion panel font-size to 14px and emphasise it with bold font-weight instead.
  • Move play button to the left of job's name, make the anchor link to job run instead of job detail view.
  • Replace play icon linking to job run with information icon linking to job detail view.
  • Show disabled jobs with lower opacity on the link in the first column, cursor: not-allowed; and grayed out description.

Screenshots

Rearranged view Explanation of changes
image image_explained

@itdependsnetworks
Copy link
Contributor

super helpful to have the explanation of change in the screenshot, thanks!

@HanlinMiao
Copy link
Contributor

Love the changes and explanation! Just need a changelog fragment and we should be good to go.

@gsnider2195
Copy link
Contributor

@lampwins what do you think of the disabled job rows being the same color as the accordion header?

Copy link
Contributor

@gsnider2195 gsnider2195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick on the color of the disabled rows. Otherwise this looks great. Thanks!

@norbert-mieczkowski-codilime
Copy link
Collaborator Author

@gsnider2195, @lampwins, good point, let me explain. Lighter grays, apart from being outside of our color palette b/c accordion header background gray is already the lightest, have too low contrast and are barely visible. On the other hand - darker grays stand out too much and instead of making disabled rows less visible they actually do the opposite. So my recommendation is to either leave the disabled row background the same as accordion header's or to not change it at all (that is leave it white).

@gsnider2195
Copy link
Contributor

@gsnider2195, @lampwins, good point, let me explain. Lighter grays, apart from being outside of our color palette b/c accordion header background gray is already the lightest, have too low contrast and are barely visible. On the other hand - darker grays stand out too much and instead of making disabled rows less visible they actually do the opposite. So my recommendation is to either leave the disabled row background the same as accordion header's or to not change it at all (that is leave it white).

make background white and description gray

@gsnider2195
Copy link
Contributor

Here's how it looks on my job list now
image

@gsnider2195 gsnider2195 merged commit 9de4a31 into next Feb 2, 2024
17 checks passed
@gsnider2195 gsnider2195 deleted the u/norbert-mieczkowski-codilime-rearrange-job-list-table-row-contents branch February 2, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants