-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: rearrange job list table row contents #5200
feature: rearrange job list table row contents #5200
Conversation
super helpful to have the explanation of change in the screenshot, thanks! |
Love the changes and explanation! Just need a changelog fragment and we should be good to go. |
@lampwins what do you think of the disabled job rows being the same color as the accordion header? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nitpick on the color of the disabled rows. Otherwise this looks great. Thanks!
@gsnider2195, @lampwins, good point, let me explain. Lighter grays, apart from being outside of our color palette b/c accordion header background gray is already the lightest, have too low contrast and are barely visible. On the other hand - darker grays stand out too much and instead of making disabled rows less visible they actually do the opposite. So my recommendation is to either leave the disabled row background the same as accordion header's or to not change it at all (that is leave it white). |
make background white and description gray |
…-list-table-row-contents
Closes #5126
What's Changed
font-size
to 14px and emphasise it with boldfont-weight
instead.cursor: not-allowed;
and grayed out description.Screenshots