Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create JSON Schema for Core Settings and Expose it via the REST API #5235

Merged
merged 23 commits into from
Feb 8, 2024
Merged

Create JSON Schema for Core Settings and Expose it via the REST API #5235

merged 23 commits into from
Feb 8, 2024

Conversation

HanlinMiao
Copy link
Contributor

Closes #5097

What's Changed

Screenshots

Screen Shot 2024-02-05 at 5 22 05 PM

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

HanlinMiao
HanlinMiao commented Feb 5, 2024
View reviewed changes
settings.json Outdated Show resolved Hide resolved
glennmatthews
glennmatthews reviewed Feb 6, 2024
View reviewed changes
nautobot/core/api/urls.py Outdated Show resolved Hide resolved
nautobot/core/api/urls.py Outdated Show resolved Hide resolved
nautobot/core/api/views.py Outdated Show resolved Hide resolved
settings.json Outdated Show resolved Hide resolved
settings.json Outdated Show resolved Hide resolved
settings.json Outdated Show resolved Hide resolved
settings.json Outdated Show resolved Hide resolved
settings.json Outdated Show resolved Hide resolved
settings.json Outdated Show resolved Hide resolved
settings.json Outdated Show resolved Hide resolved
@glennmatthews glennmatthews linked an issue Feb 6, 2024 that may be closed by this pull request
JSONSchema for core settings #5097
Closed
4 tasks
glennmatthews
glennmatthews reviewed Feb 6, 2024
View reviewed changes
settings.json Outdated Show resolved Hide resolved
glennmatthews
glennmatthews reviewed Feb 6, 2024
View reviewed changes
nautobot/core/settings.json Outdated Show resolved Hide resolved
nautobot/core/settings.json Show resolved Hide resolved
nautobot/core/settings.json Outdated Show resolved Hide resolved
glennmatthews
glennmatthews reviewed Feb 7, 2024
View reviewed changes
nautobot/core/settings.json Outdated Show resolved Hide resolved
nautobot/core/settings.json Outdated Show resolved Hide resolved
nautobot/core/settings.json Outdated Show resolved Hide resolved
nautobot/core/settings.json Outdated Show resolved Hide resolved
nautobot/core/settings.json Outdated Show resolved Hide resolved
nautobot/core/settings.json Show resolved Hide resolved
nautobot/core/settings.json Outdated Show resolved Hide resolved
glennmatthews
glennmatthews reviewed Feb 7, 2024
View reviewed changes
nautobot/core/settings.json Outdated Show resolved Hide resolved
nautobot/core/settings.json Outdated Show resolved Hide resolved
glennmatthews
glennmatthews reviewed Feb 8, 2024
View reviewed changes
nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/core/tests/test_views.py
"AUTHENTICATION_BACKENDS",
"AUTH_USER_MODEL",
"BASE_DIR",
"BRANDING_POWERED_BY_URL",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add this to the schema.

nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
nautobot/core/tests/test_views.py Outdated Show resolved Hide resolved
glennmatthews
glennmatthews approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix ruff and I think this is good to go!

@HanlinMiao
Copy link
Contributor Author

Fix ruff and I think this is good to go!

Thank you Glenn for the help and guidance!🙏

@HanlinMiao HanlinMiao merged commit 663726d into next Feb 8, 2024
17 checks passed
@HanlinMiao HanlinMiao deleted the u/hanlin-#5097 branch February 8, 2024 21:49
@glennmatthews glennmatthews mentioned this pull request Feb 9, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JSONSchema for core settings
2 participants
@HanlinMiao @glennmatthews