Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REST API for vlan-to-location and prefix-to-location M2M #5364

Merged
merged 20 commits into from
Mar 11, 2024
Merged

REST API for vlan-to-location and prefix-to-location M2M #5364

merged 20 commits into from
Mar 11, 2024

Conversation

timizuoebideri1
Copy link
Contributor

Closes #5349

What's Changed

Screenshots

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example Plugin Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@timizuoebideri1 timizuoebideri1 marked this pull request as ready for review March 4, 2024 07:46
glennmatthews
glennmatthews reviewed Mar 4, 2024
View reviewed changes
nautobot/core/testing/filters.py Outdated Show resolved Hide resolved
nautobot/ipam/filters.py Outdated Show resolved Hide resolved
nautobot/ipam/filters.py Show resolved Hide resolved
nautobot/ipam/filters.py Outdated Show resolved Hide resolved
nautobot/ipam/migrations/0049_create_vlan_location_and_prefix_location_through_models.py Outdated Show resolved Hide resolved
nautobot/ipam/models.py Outdated Show resolved Hide resolved
nautobot/ipam/models.py Outdated Show resolved Hide resolved
glennmatthews
glennmatthews reviewed Mar 5, 2024
View reviewed changes
changes/5145.added Outdated Show resolved Hide resolved
@timizuoebideri1 timizuoebideri1 force-pushed the u/timizuoebideri1-5349-vlan_prefix-to-location-m2m branch from dc662ae to c5d2c13 Compare March 6, 2024 08:51
glennmatthews
glennmatthews reviewed Mar 11, 2024
View reviewed changes
nautobot/ipam/models.py Outdated Show resolved Hide resolved
nautobot/ipam/models.py Outdated Show resolved Hide resolved
nautobot/ipam/tests/test_filters.py Outdated Show resolved Hide resolved
nautobot/ipam/tests/test_filters.py Outdated Show resolved Hide resolved
glennmatthews
glennmatthews approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming tests pass. :-) Thanks!

@timizuoebideri1 timizuoebideri1 merged commit 8a32601 into next Mar 11, 2024
17 checks passed
@timizuoebideri1 timizuoebideri1 deleted the u/timizuoebideri1-5349-vlan_prefix-to-location-m2m branch March 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@timizuoebideri1 @glennmatthews