Renamed HardwareFamily to DeviceFamily.
#5418
Conversation
changes/3559.added
Outdated
| @@ -1,2 +1,2 @@ | |||
| Added `HardwareFamily` model class. | |||
| Added `hardware_family` field to Device Type model class. | |||
| Added `DeviceFamily` model class. | |||
There was a problem hiding this comment.
I think these are changes for issue #3559, and should be left that way?
There was a problem hiding this comment.
We don't have a defined standard for maintaining "pre-release" changelog fragments, but I understand the reasoning here - it's potentially confusing to the user when we ship 2.2 for the "added" to refer to things that weren't added as described. On the flip side, it's good for the change fragments to document the actual work done. Perhaps something like the following might be a good compromise?
| Added `DeviceFamily` model class. | |
| Added `HardwareFamily` model class. (Renamed before release to `DeviceFamily`.) |
changes/3559.added
Outdated
| @@ -1,2 +1,2 @@ | |||
| Added `HardwareFamily` model class. | |||
| Added `hardware_family` field to Device Type model class. | |||
| Added `DeviceFamily` model class. | |||
There was a problem hiding this comment.
We don't have a defined standard for maintaining "pre-release" changelog fragments, but I understand the reasoning here - it's potentially confusing to the user when we ship 2.2 for the "added" to refer to things that weren't added as described. On the flip side, it's good for the change fragments to document the actual work done. Perhaps something like the following might be a good compromise?
| Added `DeviceFamily` model class. | |
| Added `HardwareFamily` model class. (Renamed before release to `DeviceFamily`.) |
nautobot/dcim/api/urls.py
Outdated
| router.register("device-families", views.DeviceFamilyViewSet) | ||
| router.register("manufacturers", views.ManufacturerViewSet) |
There was a problem hiding this comment.
Nit, but maybe swap the order of these two for consistency?
| @@ -227,17 +227,17 @@ | |||
| ), | |||
| ), | |||
| NavMenuItem( | |||
There was a problem hiding this comment.
Were we going to move Device Families above Manufacturers in the nav as a part of this PR, or is that still up in the air? @lampwins
Closes #5352
What's Changed
Pretty Straightforward change here but please do a sanity check to see if I missed any places.
Screenshots
TODO