Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device modules #5657

Merged
merged 125 commits into from
Jun 3, 2024
Merged

Add device modules #5657

merged 125 commits into from
Jun 3, 2024

Conversation

gsnider2195
Copy link
Contributor

@gsnider2195 gsnider2195 commented May 1, 2024 •
edited

Closes #2101

What's Changed

This is the feature branch for the device modules feature

Screenshots

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • Documentation Updates (when adding/changing features)
  • Example App Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design
  • Add name field to ModuleBay and ModuleBayTemplate and remove uniqueness constraint on position field
  • Templating names when instantiating a module component #5730

glennmatthews
glennmatthews reviewed May 1, 2024
View reviewed changes
nautobot/dcim/api/urls.py Outdated Show resolved Hide resolved
nautobot/dcim/factory.py Outdated Show resolved Hide resolved
nautobot/dcim/factory.py Outdated Show resolved Hide resolved
nautobot/dcim/tests/test_api.py Outdated Show resolved Hide resolved
@gsnider2195 gsnider2195 changed the title Add device modules (models and REST API) Add device modules (models and migrations) May 1, 2024
gsnider2195
gsnider2195 commented May 1, 2024
View reviewed changes
nautobot/dcim/models/device_component_templates.py


@extras_features("custom_validators")
class ModuleBayTemplate(BaseModel, ChangeLoggedModel, CustomFieldModel, RelationshipModel):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be a subclass of ModularComponentTemplateModel? We would need to make the name field optional

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, could subclass and override name to optional for this specific model, but that might be iffy if there's code assuming that all ComponentTemplateModels have a name?

HanlinMiao
HanlinMiao reviewed May 2, 2024
View reviewed changes
nautobot/dcim/factory.py Outdated Show resolved Hide resolved
nautobot/dcim/models/device_components.py Outdated Show resolved Hide resolved
nautobot/dcim/models/devices.py Show resolved Hide resolved
nautobot/dcim/models/devices.py Outdated Show resolved Hide resolved
nautobot/dcim/models/devices.py Outdated Show resolved Hide resolved
nautobot/dcim/models/devices.py Outdated Show resolved Hide resolved
glennmatthews
glennmatthews approved these changes May 2, 2024
View reviewed changes
nautobot/dcim/migrations/0060_module_models.py Outdated Show resolved Hide resolved
nautobot/dcim/models/device_component_templates.py


@extras_features("custom_validators")
class ModuleBayTemplate(BaseModel, ChangeLoggedModel, CustomFieldModel, RelationshipModel):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, could subclass and override name to optional for this specific model, but that might be iffy if there's code assuming that all ComponentTemplateModels have a name?

nautobot/dcim/models/device_components.py Show resolved Hide resolved
nautobot/dcim/models/devices.py Outdated Show resolved Hide resolved
nautobot/dcim/models/devices.py Show resolved Hide resolved
nautobot/dcim/tests/test_models.py Outdated Show resolved Hide resolved
gsnider2195 and others added 3 commits May 2, 2024 15:51
@gsnider2195
model docs
79ae348
@gsnider2195
more docs
a6f7593
@gsnider2195 @glennmatthews
Update nautobot/dcim/models/devices.py
332a529 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@gsnider2195 gsnider2195 marked this pull request as ready for review May 2, 2024 21:10
@gsnider2195
update factories to account for generic test
9252dc6
@gsnider2195
Merge remote-tracking branch 'origin/next' into u/gas-2101-device-mod…
1629f21 
…ules
@gsnider2195
Merge branch 'u/gas-2101-device-modules' into u/gas-2101-device-modul…
1e3501d 
…es-ui
@gsnider2195
reorder migrations
22cee27
@gsnider2195
Merge branch 'u/gas-2101-device-modules' into u/gas-2101-device-modul…
5592f11 
…es-ui
@gsnider2195
fix tests
5e5b1b7
@gsnider2195
fix migrations for django 4
69ae60b
@gsnider2195
Merge branch 'u/gas-2101-device-modules' into u/gas-2101-device-modul…
fba2b75 
…es-ui
@gsnider2195
make device component templates not static group associable
5a51260
@gsnider2195
disable fragile generic test
0beeec8
@gsnider2195
fix and reenable flakey test
d62cf92
@gsnider2195
fix test again
dfcdac2
@gsnider2195
these tests were passing earlier today
890660c
@gsnider2195
fix tests
0bbae89
@gsnider2195
fix tests
ff4958a
@gsnider2195
revert factory max length change
dca892d
@gsnider2195
fix minor issue with unbound front port create form
ad82b9d
@gsnider2195
fix test
60bb4f5
@gsnider2195
update display name for device
85b16af
@gsnider2195
linkify manufacturer column on device type and module type list views
57f2313
@gsnider2195
fix test
88b2481
@gsnider2195
move view test setup into the setuptestdata method instead of overloa…
b310396 
…ding the base class test
@gsnider2195
fix tests
8a35b58
@gsnider2195
cleanup, fix flaky integration test
bba8603
@gsnider2195
Merge pull request #5724 from nautobot/u/gas-2101-device-modules-ui
af57f97 
Device modules UI
@gsnider2195
Merge remote-tracking branch 'origin/next' into u/gas-2101-device-mod…
6d8f4b9 
…ules
@gsnider2195
fix conflicting merge
4190c17
@gsnider2195 gsnider2195 marked this pull request as ready for review June 3, 2024 14:33
@gsnider2195 gsnider2195 merged commit 5c7792b into next Jun 3, 2024
17 checks passed
@gsnider2195 gsnider2195 deleted the u/gas-2101-device-modules branch June 3, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glennmatthews glennmatthews glennmatthews approved these changes

@jerej jerej jerej left review comments

@HanlinMiao HanlinMiao HanlinMiao left review comments

@timizuoebideri1 timizuoebideri1 timizuoebideri1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gsnider2195 @glennmatthews @jerej @HanlinMiao @timizuoebideri1