[Tests and Doc] Implemented SavedView Model #5678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nautobot/users/factory.py
Outdated
| reverse(list_view_name) | ||
| VIEW_NAMES.append(f"{app_label}:{model}_list") | ||
| except NoReverseMatch: | ||
| pass |
There was a problem hiding this comment.
Do we have any SavedView models that are missing list-views? That would seem like a bug to me.
There was a problem hiding this comment.
consoleport template and other templates are missing list views. This try and except block is attempting to exclude them.
There was a problem hiding this comment.
Right, but doesn't that mean we should set those models to is_saved_view_model = False for now?
There was a problem hiding this comment.
Can we remove the except: pass now?
nautobot/docs/user-guide/feature-guides/images/saved-views/clear-view-button.png
Outdated
Show resolved
Hide resolved
| <div class="modal-body"> | ||
| {% csrf_token %} | ||
| <div class="form-group"> | ||
| {% render_field form.name %} | ||
| <input type="hidden" id="view" name="view" value="{{view}}"> | ||
| <input type="hidden" id="params" name="params" value="{{params}}"> |
There was a problem hiding this comment.
Did you test whether we need to urlencode params here if it contains special characters?
There was a problem hiding this comment.
Special characters are already encoded in params as you can see in the screenshot, e.g. # to %23. We actually have to decode it in the backend with unquote from urllib.parse
nautobot/users/factory.py
Outdated
| reverse(list_view_name) | ||
| VIEW_NAMES.append(f"{app_label}:{model}_list") | ||
| except NoReverseMatch: | ||
| pass |
There was a problem hiding this comment.
Can we remove the except: pass now?
nautobot/users/tests/test_views.py
Outdated
Comment on lines
265
to
266
| # Custom action requires custom permission | ||
| self.add_permissions("users.clear_savedview") |
There was a problem hiding this comment.
That's definitely not ideal... will be a tripping point for users setting up permissions.
glennmatthews
approved these changes
May 15, 2024
HanlinMiao
added a commit
that referenced
this pull request
May 18, 2024
* first commit * model changes * various changes to make update current view working * create new view complete * change savedview to a changelogged model * hacking table_config workflow together * material design icons update * Last UI changes * added changelogs * address feedback from standup and PR * more refactoring * added SavedViewMixin and refactored models based on that * fix unittests * ruff fix * unittests * unittests * address most PR feedback * unittests * address PR feedback * refactor table_config, pagination_count, filter_params and sort_order into one field config * address review feedback * use urllib.parse.urlencode * address review feedback * revert changes from users: to user: * revert minor change * user vs users * address PR feedback * address PR feedback * Make 'saved_view=...' query param imply the correct filtering, sorting, config, and pagination values (#5682) * Make 'saved_view=...' query param imply the correct filtering, sorting, config, and pagination values * Fix update behavior and create behavior when given an existing instance * Test fix * [Tests and Doc] Implemented SavedView Model (#5678) * added factories and some documentation * added api and view tests * filter test and ruff fix * include savedview.md in nav * delete print statement * user factory modifications * fix user unittest * delete comment * address PR feedback * add additional tests * factory changes * delete output.txt * added saved view clear view * added all_filters_removed non_filter_params * added tooltip title to asterik * added user guide for creating and updating saved view * added refereneces to user guide * completed user guide * refactor create saved view * address some pr feedback * refactored SavedViewModal * attempt to fix unittests * fix screenshots * specify is_saved_view_model=False on ComponentTemplateModel * added clear_view_modal * fixed saved view edit url * address pr feedback on user guide * fix all unittests * markdownlint * fix unittest * ruff * fix factory and tests * refactored SavedViewClearView to custom action on SavedViewUIViewSet * address PR feedback * ruff fix * pylint and unittest fixes * fix unittest * address pr feedabck * refactor and remove is_saved_view_model=False on StaticGroup * ruff fix * unittests * Enforce users:change_savedview instead of users:clear_savedview * pylint * fix clear_view_modal bug * address PR feedback * add json blob on saved_view_modal * gray out json blob on saved_view_modal * move get_table_class_string_from_view_name() to nautobot.core.utils.lookup * update migration file * include missing savedview doc * refactor StaticGroupFactory * unittests --------- Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1758
What's Changed
Test and documentation update for SavedView Model.
TODO