Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic group permissions improvements #5757

Conversation

glennmatthews
Copy link
Contributor

@glennmatthews glennmatthews commented May 24, 2024

Closes #n/a

What's Changed

  • Make dynamic groups /members/ API endpoint only return the members that a user has permission to view
  • Make dynamic groups detail UI only show members that a user has permission to view
  • Make object dynamic-groups detail tab only show DGs that a user has permission to view.
  • Add test coverage for the above.

If accepted, we'll also want to:

TODO

  • Explanation of Change(s)
  • Added change log fragment(s) (for more information see the documentation)
  • n/a Attached Screenshots, Payload Example
  • Unit, Integration Tests
  • n/a Documentation Updates (when adding/changing features)
  • n/a Example App Updates (when adding/changing features)
  • Outline Remaining Work, Constraints from Design

@glennmatthews
Copy link
Contributor Author

I'll add a change fragment and merge this on Tuesday.

@glennmatthews glennmatthews merged commit 4d1ff2a into develop May 28, 2024
17 checks passed
@glennmatthews glennmatthews deleted the u/glennmatthews-enforce-permissions-on-dynamicgroup-members branch May 28, 2024 15:29
@glennmatthews glennmatthews mentioned this pull request May 28, 2024
edwardtheharris pushed a commit to edwardtheharris/nautobot that referenced this pull request Jul 15, 2024
* Enforce user object permissions when viewing Dynamic Group members

* Also enforce user permissions when viewing the DGs that an object is a member of
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants