533 Fix Custom Fields after job failure #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmatthews
approved these changes
Jul 1, 2021
dgarros
reviewed
Jul 2, 2021
|
@nniehoff If you could please address the feedback and the merge conflict you would be my hero for the day. |
Revise the docstring for `fix_custom_fields` command
jathanism
added a commit
that referenced
this pull request
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #533
This PR addresses the comments from @lampwins on #533:
nautobot_server fix_custom_fieldshas been added to cleanup objects' custom fields in the case the job has failed.This PR with the addition of Celery in 1.1 as part of #223 should completely fix this issue.