Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs clarification on naming jinja filters file #692

Merged
merged 2 commits into from Jul 14, 2021
Merged

Docs clarification on naming jinja filters file #692

merged 2 commits into from Jul 14, 2021

Conversation

jmcgill298
Copy link
Contributor

Fixes: #

Proposing a clarification in docs

glennmatthews
glennmatthews approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! One suggested change in phrasing, otherwise looks great.

nautobot/docs/plugins/development.md Outdated Show resolved Hide resolved
@jmcgill298 @glennmatthews
Update nautobot/docs/plugins/development.md
aea4475 
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
@jmcgill298
Copy link
Contributor Author

Thanks @glennmatthews I have implemented the suggestiong

jathanism
jathanism approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jmcgill298 for the contribution!

@jathanism jathanism merged commit cbf99aa into nautobot:develop Jul 14, 2021
jathanism added a commit that referenced this pull request Jul 14, 2021
@jathanism
Added changelog for #692
12bcc98
@jmcgill298 jmcgill298 deleted the jinja_docs branch March 14, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jathanism jathanism jathanism approved these changes

@glennmatthews glennmatthews glennmatthews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmcgill298 @jathanism @glennmatthews