JobResult list view to show job Meta.name where available instead of class_path #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellerve
reviewed
Aug 9, 2021
hellerve
approved these changes
Aug 9, 2021
|
Also updated the homepage panel as well now:
|
hellerve
reviewed
Aug 10, 2021
You're absolutely right! I'll refactor it. |
|
|
|
Looks good to me now! |
hellerve
added a commit
to hellerve/nautobot
that referenced
this pull request
Aug 12, 2021
* next: (37 commits) Add release-notes for nautobot#229 and nautobot#472 JobResult list view to show job Meta.name where available instead of class_path (nautobot#775) Bump version to 1.1.3-beta.1 Bump version and add release date Add release-notes for nautobot#785 and nautobot#786 Prioritize LoganImporter over built-in importers. See nautobot#785 (nautobot#788) Add release-note for nautobot#789 Remove url reverse lookup from nav menu initialization (nautobot#789) Add release-note for nautobot#758 Update job docs (nautobot#758) Custom Fields View (nautobot#735) Add release-notes for nautobot#742, nautobot#771, nautobot#773 Adding Logging Examples (nautobot#771) Process NAUTOBOT_DEBUG environment var (nautobot#742) Expanding the prometheus metrics docs (nautobot#773) Add release-note for nautobot#782 Update docs and examples to reflect invoke changes made by nautobot#584 (nautobot#782) Added release-notes for nautobot#723 and bump prerelease version Updates Powerfeed Utilization Data (nautobot#772) Bump version and release date. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #472
In the JobResult list view, default to a column showing the associated Job's
Meta.namestring (where available) rather than theclass_path. (Will fall back toclass_pathif the associated Job has been deleted or is otherwise unavailable to introspect). This makes it consistent with the JobResult detail view, which was already displaying theMeta.nameif available.I also removed the
job_idUUID column from the table as being pretty much unnecessary.