Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with inconsistent view regarding the job_jobresult.html page #865

Closed
wants to merge 1 commit into from

Conversation

FloLaco
Copy link
Contributor

@FloLaco FloLaco commented Aug 27, 2021

Fixes: #864

Reproduce the same web page as job_jobresult.html (corresponding URI : extras/jobs/results/<uuid>/)

@glennmatthews
Copy link
Contributor

Thanks for the PR! A more ideal fix would be to merge the job_jobresult.html and jobresult.html templates into a common page, but this will need some additional conditional template logic as, for example, the breadcrumbs that we display for a generic JobResult are different than those for a Job-specific JobResult. Similarly, we'd ideally want to consolidate JobResultView and JobJobResultView as well.

@FloLaco
Copy link
Contributor Author

FloLaco commented Aug 30, 2021

@glennmatthews Do you prefer to reject this PR or do you want to accept it and log the futur change needed.

Here's the new view of a Job result :
image

Here's the new view of a Git clone job result :
image

@smk4664
Copy link
Contributor

smk4664 commented Oct 25, 2021

So, I am also trying to tackle this in my PR for adding a model for Job Log messages. I incorporated your changes into my PR. #1030

@glennmatthews
Copy link
Contributor

Thank you for the PR! Since this will be addressed as part of #1030, I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent job result webpage
3 participants