Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #547: Hide social auth #877

Merged
merged 3 commits into from
Sep 8, 2021

Conversation

carbonarok
Copy link
Contributor

@carbonarok carbonarok commented Sep 2, 2021

Fixes: #547

In the Django Admin, I've hidden the social auth by unregistering Association, Nonce, UserSocialAuth.

Screenshot 2021-09-07 at 09 26 35

@carbonarok carbonarok changed the base branch from develop to next September 2, 2021 10:01
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Can you provide a screenshot of the updated Admin page?

@nniehoff
Copy link
Contributor

nniehoff commented Sep 2, 2021

Why remove these? I can see them potentially being useful in environments which use SSO

nautobot/core/admin.py Outdated Show resolved Hide resolved
@carbonarok
Copy link
Contributor Author

@nniehoff currently we have no usecases for these models so think it would be cleaner to disable them. Do you know of any use cases or have you used these models with Nautobot?

@jathanism
Copy link
Contributor

jathanism commented Sep 2, 2021

Why remove these? I can see them potentially being useful in environments which use SSO

@nniehoff If you recall, you and I had discussed this probably month ago and asserted that most of these objects are internally used and we have yet to encounter any clear use-cases for them to be used explicitly. The objects will still be available, just not in the admin. We can always bring them back if the time comes for them to be leveraged!

@nniehoff
Copy link
Contributor

nniehoff commented Sep 7, 2021

I don't have any use cases for these right now, I guess I am hesitant to remove them for the eventuality that they might be useful in troubleshooting, conversely, they might not be. Having never needed them for troubleshooting it's hard to say but I also haven't done much troubleshooting with social-auth

Copy link
Contributor

@jathanism jathanism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does what is needed. And we can still access these objects using the ORM if we need to do anything with them, or even re-enable them if a future use-case arises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate user, social auth, and system settings from Django Admin to be first-class citizens in UI/API
5 participants