Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Storybook to v7 and Utilize NextJS Framework #149

Closed
jcq opened this issue May 19, 2023 · 1 comment · Fixed by #160
Closed

Upgrade Storybook to v7 and Utilize NextJS Framework #149

jcq opened this issue May 19, 2023 · 1 comment · Fixed by #160
Assignees

Comments

@jcq
Copy link
Contributor

jcq commented May 19, 2023

Storybook 7 brings a bunch of improvements, among them the ability to use framework-specific plugins that would allow for zero-config integration with NextJS (among others):
https://storybook.js.org/blog/integrate-nextjs-and-storybook-automatically/

I would also recommend switching to using CSF3 for stories, as it tends to be cleaner and more elegant. This can be utilized in Storybook 6.5, but is the default in 7.
Example:
https://storybook.js.org/docs/react/writing-stories/introduction#default-export

@sawyerh
Copy link
Contributor

sawyerh commented Jun 24, 2023

Started working on this here: #160

@sawyerh sawyerh self-assigned this Jun 24, 2023
sawyerh added a commit that referenced this issue Jun 28, 2023
## Ticket

- Resolves #149
- Should also resolve #118

## Changes

- Upgrade from [Storybook v6 to
v7](https://storybook.js.org/blog/storybook-7-0/)
- Migrate stories from [CSF2 to
CSF3](https://storybook.js.org/blog/storybook-csf3-is-here/)

## Testing

<img width="1920" alt="CleanShot 2023-06-23 at 18 05 28@2x"
src="https://github.com/navapbc/template-application-nextjs/assets/371943/dc5627f4-f269-4cf2-bd55-6d0d5304624e">

<img width="1917" alt="CleanShot 2023-06-23 at 18 07 11@2x"
src="https://github.com/navapbc/template-application-nextjs/assets/371943/8d22d707-f74d-4447-94b9-dc57221c2f8e">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants