Migrate from Next.js Pages Router to App Router #255
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| export default function Page() { | ||
| return <>healthy</>; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| /** | ||
| * Root layout component, wraps all pages. | ||
| * @see https://nextjs.org/docs/app/api-reference/file-conventions/layout | ||
| */ | ||
| import { Metadata } from "next"; | ||
|
|
||
| import Layout from "src/components/Layout"; | ||
|
|
||
| import "src/styles/styles.scss"; | ||
|
|
||
| export const metadata: Metadata = { | ||
| icons: [`${process.env.NEXT_PUBLIC_BASE_PATH ?? ""}/img/logo.svg`], | ||
| }; | ||
|
|
||
| interface LayoutProps { | ||
| children: React.ReactNode; | ||
| params: { | ||
| locale: string; | ||
| }; | ||
| } | ||
|
|
||
| export default function RootLayout({ children, params }: LayoutProps) { | ||
| return ( | ||
| <html lang={params.locale}> | ||
| <body> | ||
| {/* Separate layout component for the inner-body UI elements since Storybook | ||
| and tests trip over the fact that this file renders an <html> tag */} | ||
| <Layout locale={params.locale}>{children}</Layout> | ||
| </body> | ||
| </html> | ||
| ); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { Metadata } from "next"; | ||
| import { isFeatureEnabled } from "src/services/feature-flags"; | ||
|
|
||
| import { getTranslations } from "next-intl/server"; | ||
|
|
||
| import { View } from "./view"; | ||
|
|
||
| interface RouteParams { | ||
| locale: string; | ||
| } | ||
|
|
||
| export async function generateMetadata({ params }: { params: RouteParams }) { | ||
|
There was a problem hiding this comment. Maybe overkill, but do you think worth linking to this section of the docs? https://nextjs.org/docs/app/api-reference/functions/generate-metadata I imagine we don't want to reference for everything, but was wondering if for things that are new for server components (which many folks may be less familiar with at first) it could help 🤷♀️ There was a problem hiding this comment. Good question. I have a follow-up ticket where I want to add more docs so will fold code comments into that scope since I think it relates. #262 |
||
| const t = await getTranslations({ locale: params.locale }); | ||
| const meta: Metadata = { | ||
| title: t("home.title"), | ||
| }; | ||
|
|
||
| return meta; | ||
| } | ||
|
|
||
| export default async function Controller() { | ||
| const isFooEnabled = await isFeatureEnabled("foo", "anonymous"); | ||
|
|
||
| return <View isFooEnabled={isFooEnabled} />; | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the /health/ page an aspect of next.js that's built in to handle some particular functionality? I couldn't find it looking in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is it's required by the infra template in order to know if the container is healthy, otherwise it spins up a new ECS task.