Karina/wmdp 199 wic before #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pbc/template-application-nextjs into karina/WMDP-61-initial-nextjs-setup
- add jest.setup.js to require jest-dom
- package.json: add react testing library, babel and jest dependencies - add first test - update jsx - yarn.lock updated with new packages
Changes added a .github folder which should store all github related processes (e.g. github actions, and templates) added PR template Context for reviewers We want to establish a consistent pull request template that we’ll use.
Co-authored-by: Rocket <rocketnova@users.noreply.github.com>
Co-authored-by: Rocket <rocketnova@users.noreply.github.com>
- Fixed the filename case conflict between `.github/PULL_REQUEST_TEMPLATE.md` and `.github/pull_request_template.md` - Updated the pull request template to be slightly more generic
* yarn create next-app --typescript * clean up auto-generated pages, public and styles * next.config.js: setup i18n locale for internationalization * next.config.js: add code comment re: internationalization * add html tags for VO * Update app/styles/Home.module.css update stickcy nav Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update app/README.md Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update app/README.md Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * tsconfig: target es6 Co-authored-by: Rocket <rocketnova@users.noreply.github.com>
* yarn create next-app --typescript * clean up auto-generated pages, public and styles * next.config.js: setup i18n locale for internationalization * next.config.js: add code comment re: internationalization * add html tags for VO * Update app/styles/Home.module.css update stickcy nav Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update app/README.md Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update app/README.md Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * tsconfig: target es6 * add babelec * add __mocks__ with mock styles for testing * -test: add first jest test and snapshot test for Home page - add jest.setup.js to require jest-dom * - add jest.config.js - package.json: add react testing library, babel and jest dependencies - add first test - update jsx - yarn.lock updated with new packages * Update app/.babelrc Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update app/package.json Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * add testRegex and testPathIgnorePatterns * setup jest-axe * add new lines add end of files * jest.config.js: add inline comments * README: add tsconfig documentation * README: add test script documentation Co-authored-by: Rocket <rocketnova@users.noreply.github.com>
* yarn create next-app --typescript * clean up auto-generated pages, public and styles * next.config.js: setup i18n locale for internationalization * next.config.js: add code comment re: internationalization * add html tags for VO * Update app/styles/Home.module.css update stickcy nav Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update app/README.md Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update app/README.md Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * tsconfig: target es6 * add babelec * add __mocks__ with mock styles for testing * -test: add first jest test and snapshot test for Home page - add jest.setup.js to require jest-dom * - add jest.config.js - package.json: add react testing library, babel and jest dependencies - add first test - update jsx - yarn.lock updated with new packages * .eslintrc.json: extend nava eslint config * package.json: add eslint-config-nava * add ts check to all js files * add dev note regarding incremental type checking * add TS-specific eslint * update read me with development typecheck and linting tips * update read me with development typecheck and linting tips * add and setup prettier * Update app/.babelrc Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update app/package.json Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * Update package.json add scripts to package.json * run prettier * add checkJs to tsconfig, remove duplicate code from js files * add typescript parser and implement type information with linting * eslintrc: add prettier recommended plugin * preettierrc: add trailing comma check, remove redundant code * README: add auto-generated modified note * Update app/README.md Co-authored-by: Rocket <rocketnova@users.noreply.github.com> * add testRegex and testPathIgnorePatterns * re-add localesubpaths to next.config.js * tsconfig.json: remove inline comment * README: add docimentation for eslint and tsconfig * setup jest-axe * add new lines add end of files * jest.config.js: add inline comments * README - add documentation for test * README: add tsconfig documentation * README: add test script documentation * README: add documentation for dependencies * yarn.lock * Update app/__mocks__/styleMock.js Co-authored-by: Rocket <rocketnova@users.noreply.github.com> Co-authored-by: Rocket <rocketnova@users.noreply.github.com>
added 16 commits
September 6, 2022 14:50
…l continue button to contact page
…mt-demo-project-eligibility-screener into karina/wmdp-165-review-page
karinamzalez
changed the base branch from
main
to
karina/wmdp-165-review-page
added 6 commits
September 16, 2022 16:12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
WMDP-199
Changes
Context for reviewers
Testing
On eligibility page:
On review page:
.