Proposal: Static Medium feed #276
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcrowe
commented
Jan 3, 2020
| @@ -6,7 +6,7 @@ HUGO_VERSION = "0.53" | |||
|
|
|||
| [build] | |||
| publish = "public" | |||
| command = "gulp sass && hugo" | |||
| command = "gulp sass && npm run data-medium && hugo" | |||
There was a problem hiding this comment.
Netlify will download the feed. You can do it manually with npm run data-medium. This should probably go into the readme or combined into package.json scripts.
tcrowe
commented
Jan 3, 2020
| @@ -23,6 +23,7 @@ | |||
| "webpack-cli": "^3.3.5" | |||
| }, | |||
| "scripts": { | |||
| "data-medium": "mkdir -p data && node tools/rss-to-json.js https://medium.com/feed/nav-coin ./data/medium.json", | |||
There was a problem hiding this comment.
Download into Hugo's data directory
tcrowe
commented
Jan 3, 2020
| <h3>Loading...</h3> | ||
| </div> | ||
| <div id="latest-news" class="card-container"> | ||
| {{ range first 8 .Site.Data.medium.items }} |
tcrowe
commented
Jan 3, 2020
| @@ -0,0 +1,15 @@ | |||
| <div class="homepage-news-card"> | |||
There was a problem hiding this comment.
This is just ported from the React js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#267 adds the Medium RSS feed and components. This PR just makes it static. No request needs to be made if you do it like this.
The parser is moved to
./tools/rss-to-json.jsand might be reused if other feeds are tapped. Netlify should pull the data before hugo renders.If you like this approach the React stuff can be backed up and used as a starting point for #269.
Issues Resolved
None are resolved. #265 #267 related.
Preview Links
https://deploy-preview-276--navhub.netlify.com/
It has the same appearance.
With a blocker this section will still render.
Checklist
Mobile emulator view