#9 proof of stake validity #18
Conversation
| @@ -360,7 +360,7 @@ case $host in | |||
|
|
|||
| AX_CHECK_LINK_FLAG([[-Wl,-headerpad_max_install_names]], [LDFLAGS="$LDFLAGS -Wl,-headerpad_max_install_names"]) | |||
| CPPFLAGS="$CPPFLAGS -DMAC_OSX" | |||
| OBJCXXFLAGS="$CXXFLAGS" | |||
| OBJCXXFLAGS="-std=c++11 $CXXFLAGS" | |||
There was a problem hiding this comment.
we will also need to add the -lcurl flag somewhere here, but that is only needed on the navtech branch currently
There was a problem hiding this comment.
Instead of directly adding -lcurl in CFLAGS, I'd add a check for the library in configure.ac. Regarding this branch everything is ok.
| @@ -1178,14 +1178,6 @@ bool AcceptToMemoryPoolWorker(CTxMemPool& pool, CValidationState& state, const C | |||
| if (tx.IsCoinStake()) | |||
| return state.DoS(100, false, REJECT_INVALID, "coinstake"); | |||
|
|
|||
| // Don't relay version 2 transactions until CSV is active, and we can be | |||
There was a problem hiding this comment.
this is the broadcast error i was hitting right? So we are happy to just remove the check? No other impact?
There was a problem hiding this comment.
I checked the code overall, it is safe to remove it.
| @@ -7769,11 +7763,11 @@ int64_t GetProofOfStakeReward(int nHeight, int64_t nCoinAge, int64_t nFees) | |||
| int64_t nRewardCoinYear; | |||
| nRewardCoinYear = MAX_MINT_PROOF_OF_STAKE; | |||
|
|
|||
| if(nHeight < 7 * DAILY_BLOCKCOUNT) | |||
| if(nHeight-1 < 7 * DAILY_BLOCKCOUNT) | |||
There was a problem hiding this comment.
looking into this, wondering why the reward is different for under 1 week
There was a problem hiding this comment.
It is like this in NavCoin original code.
https://github.com/navcoindev/navcoin2/blob/master/src/main.cpp Line 1138
Merging Master to 4.6.0-rc
Proof of Stake fully tested. Branch candidate to merge with master.