Updated all references to old Repo Address for NavCoin github current url #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguycalled
approved these changes
May 2, 2019
|
yes, navcoindev is the old account but i guess craig linked them. approved for merge |
mxaddict
changed the title
mxaddict
changed the title
aguycalled
reviewed
May 5, 2019
|
I think that it should match the repo url exactly as RFC for urls is case
sensitive.
I guess if we want we could rename the repo to lowercase as it is better
looking as a URL.
…On Sun, May 5, 2019, 17:52 alex v. ***@***.***> wrote:
***@***.**** commented on this pull request.
I prefer the lowercase writing of navcoin in the context of an URL, are
there some guidelines for this?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#463 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAIDAKMAWQSVBQENFPOMNRLPT2U4LANCNFSM4HJ7EQ2Q>
.
|
|
yes, i would rather rename the url @craigmacgregor |
|
organisation URL has been renamed to |
I've updated the PR |
proletesseract
approved these changes
May 10, 2019
|
approved, re-running travis then will merge when it passes. |
|
:/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the gitlian-linux.yml Repo Address for NavCoin
I think this only works because github does auto redirect of old repo URL?