Skip to content

Updated all references to old Repo Address for NavCoin github current url#463

Merged
mxaddict merged 1 commit into
masterfrom
patch-7
May 14, 2019
Merged

Updated all references to old Repo Address for NavCoin github current url#463
mxaddict merged 1 commit into
masterfrom
patch-7

Conversation

@mxaddict

@mxaddict mxaddict commented May 2, 2019

Copy link
Copy Markdown
Contributor

Updated the gitlian-linux.yml Repo Address for NavCoin

I think this only works because github does auto redirect of old repo URL?

@aguycalled

Copy link
Copy Markdown
Member

yes, navcoindev is the old account but i guess craig linked them. approved for merge

@mxaddict mxaddict requested a review from proletesseract May 2, 2019 17:00
@mxaddict mxaddict changed the title Updated the gitlian-linux.yml Repo Address for NavCoin Updated the gitian-linux.yml Repo Address for NavCoin May 3, 2019
@mxaddict mxaddict changed the title Updated the gitian-linux.yml Repo Address for NavCoin Updated all references to old Repo Address for NavCoin github current url May 5, 2019

@aguycalled aguycalled left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the lowercase writing of navcoin in the context of an URL, are there some guidelines for this?

@mxaddict

mxaddict commented May 5, 2019 via email

Copy link
Copy Markdown
Contributor Author

@aguycalled

Copy link
Copy Markdown
Member

yes, i would rather rename the url @craigmacgregor

@proletesseract

proletesseract commented May 8, 2019

Copy link
Copy Markdown
Member

organisation URL has been renamed to navcoin all lower case. please update PR

@mxaddict

mxaddict commented May 9, 2019

Copy link
Copy Markdown
Contributor Author

organisation URL has been renamed to navcoin all lower case. please update PR

I've updated the PR

@proletesseract

Copy link
Copy Markdown
Member

approved, re-running travis then will merge when it passes.

@proletesseract

Copy link
Copy Markdown
Member

The job exceeded the maximum time limit for jobs, and has been terminated.

:/

@mxaddict mxaddict merged commit f31382f into master May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants