Added new details for getstakinginfo error message as suggested in #288#472
Conversation
|
utACK, will compile and run locally once I see travis build pass |
|
utACK |
| vRecv >> tx; | ||
|
|
||
| LogPrint("net", "Received tx %s peer=%d\n%s\n", tx.GetHash().ToString(), pfrom->id, tx.ToString()); | ||
| LogPrint("net", "Received tx %s peer=%d\n%s\n", tx.GetHash().ToString(), pfrom->id, tx.ToString()); |
| * This function only returns the highest priority warning of the set selected by strFor. | ||
| */ | ||
| std::string GetWarnings(const std::string& strFor); | ||
| std::string GetWarnings(const std::string& strFor, bool verbose); |
There was a problem hiding this comment.
I'd consider changing the variable name to something more descriptive like fForStaking. The warnings returned when the flag is false are not less verbose than the staking-related.
|
Built and tested on OSX. Added some comments about minor suggestions |
|
Built and tested using @francisjyap Go Go Go! 💯 |
|
@aguycalled Changed the variable name as per your suggestion. Also fixed the wrong indent. |
|
Built and tested on Ubuntu 18.04 will pass the review once travis build passes. |
|
travis failed because of timeout |
mxaddict
left a comment
mxaddict
left a comment
There was a problem hiding this comment.
Looks good to me, travis build is still failing though, I think it's just a timeout.
I built locally and ran test suite, was working fine.
aguycalled
added
bounty pending payment
bounty paid
and removed
bounty pending payment
labels
3 participants
Added new details for getstakinginfo error message as suggested in #288
Errors messages are :