Added new details for getstakinginfo error message as suggested in #288 #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
utACK, will compile and run locally once I see travis build pass |
|
utACK |
aguycalled
reviewed
May 8, 2019
src/main.cpp
Outdated
| @@ -7120,7 +7142,7 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv, | |||
| CTransaction tx; | |||
| vRecv >> tx; | |||
|
|
|||
| LogPrint("net", "Received tx %s peer=%d\n%s\n", tx.GetHash().ToString(), pfrom->id, tx.ToString()); | |||
| LogPrint("net", "Received tx %s peer=%d\n%s\n", tx.GetHash().ToString(), pfrom->id, tx.ToString()); | |||
aguycalled
reviewed
May 8, 2019
src/main.h
Outdated
| @@ -289,6 +289,7 @@ bool IsInitialBlockDownload(); | |||
| * This function only returns the highest priority warning of the set selected by strFor. | |||
| */ | |||
| std::string GetWarnings(const std::string& strFor); | |||
| std::string GetWarnings(const std::string& strFor, bool verbose); | |||
There was a problem hiding this comment.
I'd consider changing the variable name to something more descriptive like fForStaking. The warnings returned when the flag is false are not less verbose than the staking-related.
|
Built and tested on OSX. Added some comments about minor suggestions |
|
Built and tested using @francisjyap Go Go Go! 💯 |
|
@aguycalled Changed the variable name as per your suggestion. Also fixed the wrong indent. |
|
Built and tested on Ubuntu 18.04 will pass the review once travis build passes. |
|
travis failed because of timeout |
mxaddict
approved these changes
May 9, 2019
aguycalled
approved these changes
May 14, 2019
aguycalled
added
bounty pending payment
bounty paid
and removed
bounty pending payment
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new details for getstakinginfo error message as suggested in #288
Errors messages are :