-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new details for getstakinginfo error message as suggested in #288 #472
Conversation
utACK, will compile and run locally once I see travis build pass |
utACK |
src/main.cpp
Outdated
@@ -7120,7 +7142,7 @@ bool static ProcessMessage(CNode* pfrom, string strCommand, CDataStream& vRecv, | |||
CTransaction tx; | |||
vRecv >> tx; | |||
|
|||
LogPrint("net", "Received tx %s peer=%d\n%s\n", tx.GetHash().ToString(), pfrom->id, tx.ToString()); | |||
LogPrint("net", "Received tx %s peer=%d\n%s\n", tx.GetHash().ToString(), pfrom->id, tx.ToString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong indent
src/main.h
Outdated
@@ -289,6 +289,7 @@ bool IsInitialBlockDownload(); | |||
* This function only returns the highest priority warning of the set selected by strFor. | |||
*/ | |||
std::string GetWarnings(const std::string& strFor); | |||
std::string GetWarnings(const std::string& strFor, bool verbose); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd consider changing the variable name to something more descriptive like fForStaking. The warnings returned when the flag is false are not less verbose than the staking-related.
Built and tested on OSX. Added some comments about minor suggestions |
Built and tested using @francisjyap Go Go Go! 💯 |
@aguycalled Changed the variable name as per your suggestion. Also fixed the wrong indent. |
Built and tested on Ubuntu 18.04 will pass the review once travis build passes. |
travis failed because of timeout |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, travis build is still failing though, I think it's just a timeout.
I built locally and ran test suite, was working fine.
Added new details for getstakinginfo error message as suggested in #288
Errors messages are :