Skip to content

default .conf#504

Merged
aguycalled merged 1 commit intonavcoin:masterfrom
alexeyneu:master
Jun 6, 2019
Merged

default .conf#504
aguycalled merged 1 commit intonavcoin:masterfrom
alexeyneu:master

Conversation

@alexeyneu
Copy link
Contributor

@alexeyneu alexeyneu commented Jun 2, 2019

No description provided.

@alexeyneu
Copy link
Contributor Author

alexeyneu commented Jun 2, 2019

outStream.close();

waste coz it's closed by end-of-scope

@mxaddict
Copy link
Contributor

mxaddict commented Jun 3, 2019

outStream.close();

waste coz it's closed by end-of-scope

Not sure what you mean by this.

But the changes look good, I will test once I get some spare time.

@alexeyneu
Copy link
Contributor Author

alexeyneu commented Jun 4, 2019

outStream.close();

waste coz it's closed by end-of-scope

Not sure what you mean by this.

But the changes look good, I will test once I get some spare time.

i mean that it closes as it goes out of scope even without this line.

@mxaddict
Copy link
Contributor

mxaddict commented Jun 4, 2019

Ahh, I see.

@mxaddict
Copy link
Contributor

mxaddict commented Jun 4, 2019

testedACK (Ubuntu 18.04)

Default file created successfully nice work @alexeyneu

@mxaddict
Copy link
Contributor

mxaddict commented Jun 4, 2019

This closes #407

@aguycalled
Copy link
Member

tested OSX, could you share a Nav address for the bounty payment? @alexeyneu

@mxaddict
Copy link
Contributor

mxaddict commented Jun 4, 2019

OFF TOPIC, @alexeyneu what is your handle on navcoin discord? 👍

@alexeyneu
Copy link
Contributor Author

NSBWLZUn5cYFsS74LjyyD6kkTX3txfT9pL

@aguycalled
Copy link
Member

Paid edf746f8aaaa81e7300c75bd38585256ad3c2e13a17455844ccf203da6e7a251

@aguycalled aguycalled merged commit 940c669 into navcoin:master Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants