Staking reward setup GUI #605

aguycalled · 2019-09-20T22:57:47Z

This PR adds a new GUI to set up different ways to split the staking rewards. Setup can be done generally for every address or individually per staking address.

Works for both hot and cold staking methods.

Includes the following hardcoded addresses:

{"NN5QSSMAdtRU35BffLZUw9vChnhHKKMeuL", "Alex aguycalled - Core Dev"},
{"NRXfZ1egFxMSUsc4Ufpi4Lm7DdXStYmeBG", "mxaddict - Core Dev"},
{"3HnzbJ4TR9", "Community Fund"},
{"XVPMwBdNU9ou3a3TnwaVgAgEecbdsEVZHbVmeY4TMAHbY6BdtY8xW6m1Q1rkb", "Core Dev Bounty"},
{"XAznGHuQ35hvgSGsVWi5Nu2Y6n3rT4cycE3yfZWCfnNjycCGdGAEnta2G24Mi", "Web Dev Bounty"}

Please comment in this pull request to add other community member addresses.

chasingkirkjufell · 2019-09-23T22:15:54Z

built and tested locally on ubuntu 18.04. it worked as expected. made a couple suggestions on handling the default settings.
the receiving stakes will display 2 NAV no mater how ever much the % is if the staking address and the receiving addresses both belong to the same wallet.dat. not likely to be encountered and the actual amount is accurate despite showing 2 NAV.

chasingkirkjufell · 2019-09-24T14:16:50Z

the new drop down is empty and nothing happens after clicking.

aguycalled · 2019-09-24T16:30:14Z

should be fixed now @chasingkirkjufell

chasingkirkjufell · 2019-09-24T18:45:48Z

in cold-staking mode, staking node stake redirection did not work when choosing the cold-staking address from the drop down list and then point to an address that belongs to staking node. it only worked when the redirection address was set under "default" rather than "cold-staking address".

Edit: also doesn't work if pointed to a 3rd unrelated wallet address. so basically choosing the cold-staking address from the drop down list and then set a redirection address does not work.

aguycalled · 2019-09-24T22:04:29Z

this happens because the wallet looks for the configuration for the staking address of the cold staking address which owns the coins that are staking. i've updated the gui so it only shows the staking address instead of the long cold staking one. does it sound like a good solution?

chasingkirkjufell · 2019-09-24T22:17:09Z

should be fine if the amount it's cold-staking is also shown so users don't have to figure out which address they used. the questions though will be what will it show if somehow someone send coins to the staking address, will it show the cold-staking amount or the amount in the address? will test it tomorrow.

aguycalled · 2019-09-24T22:41:18Z

it will show both

mxaddict

utACK, building now

chasingkirkjufell · 2019-09-25T14:12:08Z

when receiving re-directed hot-staking or cold-staking, the transaction history shows receiving 0 NAV instead of the redirected amount on the re-directed address.

coin control shows the correct amount.

aguycalled · 2019-09-25T14:13:15Z

how is it shown in listtransactions?

chasingkirkjufell · 2019-09-25T14:14:37Z

0

aguycalled · 2019-09-25T17:25:47Z

should be fixed now

chasingkirkjufell · 2019-09-25T17:30:20Z

setting window width increases with the amount of addresses set and cannot be decreased.

http://giphygifs.s3.amazonaws.com/media/njYrp176NQsHS/giphy.gif :P

aguycalled · 2019-09-25T17:37:10Z

fixed

chasingkirkjufell · 2019-09-25T18:10:55Z

users are able to set 0% contribution to an address, which is fine, but the receiving address will actually see it. could it be used to bloat the blockchain if someone just set infinite numbers of addresses getting 0%?

chasingkirkjufell · 2019-09-25T19:04:15Z

when setting both default redirection address and individual address redirection address, redirection will stop after setting individual address and then removing it while it shouldn't since the default should still redirect it to the set address.

a uncommon situation but when cold-staking, the spending wallet redirection drop down will show the staking address as well as the spending address tied to it as separate addresses. uncommon since if someone is cold-staking, they won't need to use redirection on the spending wallet.

chasingkirkjufell · 2019-09-26T13:14:19Z

wait, i might have made a mistake

chasingkirkjufell · 2019-09-26T13:23:57Z

my bad, cold-staking redirecting to another cold-staking address works just fine. i opened the wrong wallet and redirected to myself that was why i couldn't see any contribution difference. and a hot-staking node can redirect stakes to a cold-staking address normally. so the irregularity is only when a node is both hot-staking and cold-staking.

chasingkirkjufell · 2019-09-26T13:40:18Z

okay, narrowed down. if a node is cold-staking and hot staking, hot staking stake redirection works normally unless the redirected address is the long cold-staking address which the wallet owns the staking address, then the incorrect amount will be shown. the correct amount is shown if hot-stakes redirected to just the staking address of the cold-staking address. only doesn't work when redirected to the long cold-staking address the wallet is staking with.

aguycalled · 2019-09-26T16:21:07Z

could you share a screenshot of your rewards setup?

chasingkirkjufell · 2019-09-26T16:59:51Z

chasingkirkjufell · 2019-09-26T18:50:43Z

Yeah the spending address in my situation belongs to another wallet. The problem comes when a normal address of the staking node and belongs to the staking node wallet finds a block and redirects it to a long cold staking address of which the staking node only owns the staking address and not the spending address

chasingkirkjufell · 2019-09-26T18:51:37Z

Kind of proud that I could find that problem tbh :P

mxaddict · 2019-09-26T18:53:12Z

That's a pretty niche issue. But i guess it's a valid use case.

…

On Fri, Sep 27, 2019, 02:51 chasingkirkjufell ***@***.***> wrote: Kind of proud that I could find that problem tbh :P — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#605?email_source=notifications&email_token=AAIDAKKQ7VW6IG3YDNKCKXTQLUADVA5CNFSM4IY36MN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7WTCEI#issuecomment-535638289>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIDAKOVWQAE6TT7SZIUAD3QLUADVANCNFSM4IY36MNQ> .

aguycalled · 2019-09-26T18:58:30Z

@chasingkirkjufell i wanted to send you some navs from the dev bounty for helping testing if you could share a nav address 😉

chasingkirkjufell · 2019-09-26T18:59:22Z

sure. really appreciate it. :)
NL9jPW75P4kNMdvQmFBpYVkZ3sABQtXfYY

mxaddict · 2019-09-26T19:02:23Z

❤️❤️❤️

…

On Fri, Sep 27, 2019, 02:59 chasingkirkjufell ***@***.***> wrote: sure. really appreciate it. :) NL9jPW75P4kNMdvQmFBpYVkZ3sABQtXfYY — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#605?email_source=notifications&email_token=AAIDAKK5L6CG33O3OBUIVXDQLUBAVA5CNFSM4IY36MN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7WTZTI#issuecomment-535641293>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAIDAKIFQ4PJ4BGX2RTENPLQLUBAVANCNFSM4IY36MNQ> .

aguycalled · 2019-09-26T19:27:28Z

i think i got it fixed now

chasingkirkjufell · 2019-09-26T20:06:04Z

tested and worked well. all redirection possibilities worked as expected. the only imperfection is what i mentioned before but it doesn't affect functionality. good job!

#605 (comment)

mxaddict · 2019-09-26T20:14:39Z

@aguycalled can you add my address to this list? :)

NRXfZ1egFxMSUsc4Ufpi4Lm7DdXStYmeBG

mxaddict · 2019-09-26T20:26:59Z

src/qt/splitrewards.h

@@ -24,6 +24,7 @@
 #include <QVBoxLayout>

 static QMap<QString, QString> teamAddresses = {{"NN5QSSMAdtRU35BffLZUw9vChnhHKKMeuL", "Alex aguycalled - Core Dev"},
+                                               {"NRXfZ1egFxMSUsc4Ufpi4Lm7DdXStYmeBG", "mxaddict - Core Dev"},


aguycalled · 2019-09-27T14:41:25Z

Paid 2,800NAV to NL9jPW75P4kNMdvQmFBpYVkZ3sABQtXfYY
300 (minor ux issue) + 600 (major ux issue) + 600 (major ux issue) + 600 (major ux issue) + 100 (visual glitch) + 300 (minor ux issue) + 300 (minor ux issue)
339db52e68ca2937bc36fe38addca5d6e15333cbaf54de4045d76400d0e05aed

chasingkirkjufell · 2019-09-27T14:52:47Z

thanks a lot!! :D

proletesseract · 2019-10-06T04:08:38Z

Compiles & Runs on OSX 10.14.5. Seems like there's been some pretty rigorous testing on this one so far. My only real feedback is adding a button to the staking section on the overview page which also launches the staking setup window to drive people to consider using it more than just hidden away in the menu. I've committed the change adding the button. If you don't think we should have the button there we can roll it back.

I've also added a donation address for me :)

… donation address

aguycalled · 2019-10-06T15:17:28Z

src/qt/overviewpage.h

@@ -61,11 +62,11 @@ public Q_SLOTS:
    void updateStakeReportNow();
    void updateStakeReportbalanceChanged(CAmount, CAmount, CAmount, CAmount, CAmount, CAmount, CAmount);
    void setVotingStatus(QString text);
-
+    void on_pushButton_clicked();


@proletesseract could we maybe use another name for this method? it reads very generic and does not refer to its real meaning

Sure, that was just what was autogenerated by QT Creator. I'll commit the change when i get a chance.

gui for splitting staking rewards

6da6366

aguycalled added needed for final release ready for review labels Sep 20, 2019

aguycalled requested review from mxaddict and proletesseract September 20, 2019 22:57

skip invalid address/empty json object

6341cfb

combobox with addresses

a6d2b4e

fix dialog

bfba552

show coldstaking by staking address

d27c584

mxaddict reviewed Sep 25, 2019

View reviewed changes

alex v added 2 commits September 25, 2019 18:32

fix gui tx list

244ad8a

fix listtransactions rpc accounting

c64bab1

fix line wrap

6054aae

alex v added 2 commits September 25, 2019 20:23

ignore 0% addresses

05d3956

fix typo

84b7727

fix calculation reward

93445c2

add mxaddict address

93b5fdb

mxaddict reviewed Sep 26, 2019

View reviewed changes

added "setup staking rewards" button on the overview page and also my…

7b3003f

… donation address

proletesseract approved these changes Oct 6, 2019

View reviewed changes

aguycalled commented Oct 6, 2019

View reviewed changes

changed pushbutton name to be more descriptive

869676c

chasingkirkjufell approved these changes Oct 8, 2019

View reviewed changes

proletesseract closed this Oct 8, 2019

proletesseract reopened this Oct 8, 2019

proletesseract merged commit 0b8cb5d into navcoin:master Oct 8, 2019

This was referenced Feb 19, 2020

Implement a GUI for re-directing stakes #584

Closed

Allow accumulation of the cold staking reward in different addresses. #599

Closed

Staking reward setup GUI #605

Staking reward setup GUI #605

Conversation

aguycalled commented Sep 20, 2019 • edited Loading

chasingkirkjufell commented Sep 23, 2019

chasingkirkjufell commented Sep 24, 2019

aguycalled commented Sep 24, 2019

chasingkirkjufell commented Sep 24, 2019 • edited Loading

aguycalled commented Sep 24, 2019

chasingkirkjufell commented Sep 24, 2019

aguycalled commented Sep 24, 2019

mxaddict left a comment

Choose a reason for hiding this comment

chasingkirkjufell commented Sep 25, 2019

aguycalled commented Sep 25, 2019

chasingkirkjufell commented Sep 25, 2019

aguycalled commented Sep 25, 2019

chasingkirkjufell commented Sep 25, 2019

aguycalled commented Sep 25, 2019

chasingkirkjufell commented Sep 25, 2019

chasingkirkjufell commented Sep 25, 2019

chasingkirkjufell commented Sep 26, 2019

chasingkirkjufell commented Sep 26, 2019

chasingkirkjufell commented Sep 26, 2019

aguycalled commented Sep 26, 2019

chasingkirkjufell commented Sep 26, 2019

chasingkirkjufell commented Sep 26, 2019

chasingkirkjufell commented Sep 26, 2019

mxaddict commented Sep 26, 2019 via email

aguycalled commented Sep 26, 2019

chasingkirkjufell commented Sep 26, 2019

mxaddict commented Sep 26, 2019 via email

aguycalled commented Sep 26, 2019

chasingkirkjufell commented Sep 26, 2019

mxaddict commented Sep 26, 2019

mxaddict Sep 26, 2019

Choose a reason for hiding this comment

aguycalled commented Sep 27, 2019

chasingkirkjufell commented Sep 27, 2019

proletesseract commented Oct 6, 2019

aguycalled Oct 6, 2019

Choose a reason for hiding this comment

proletesseract Oct 6, 2019

Choose a reason for hiding this comment

aguycalled commented Sep 20, 2019 •

edited

Loading

chasingkirkjufell commented Sep 24, 2019 •

edited

Loading