Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable CFund client functionality #623

Merged
merged 2 commits into from
Nov 13, 2019

Conversation

aguycalled
Copy link
Member

This Pull Request disables on the client the creation of proposals and payment requests in mainnet. Other networks or network validation are not affected.

Disabled RPC commands:
createpaymentrequest
createproposal

Disabled GUI functionality:
Proposal creation
Payment Request creation

Copy link
Contributor

@mxaddict mxaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testedACK, changes make sense, and I tested a wallet built with this PR and performed as expected.

@mxaddict
Copy link
Contributor

tested Scenarios:

  • mainnet node

    • Could not create via GUI
    • Could not create via CLI / Debug Console
  • devnet node

    • Could create via GUI
    • Could create via CL I/ Debug Console

Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on 18.04

Scenarios:

mainnet node

Could not create via GUI
Could not create via CLI / Debug Console
devnet node

Could create via GUI
Could create via CL I/ Debug Console

@aguycalled aguycalled merged commit 09ea936 into navcoin:master Nov 13, 2019
@aguycalled aguycalled deleted the disable-cfund-client branch November 13, 2019 22:29
aguycalled pushed a commit to aguycalled/navcoin-core that referenced this pull request Dec 5, 2019
* disable cfund client functionality

* enable vote
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants