Disable CFund client functionality #623
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aguycalled
requested review from
chasingkirkjufell,
mxaddict and
proletesseract
mxaddict
approved these changes
Nov 12, 2019
Contributor
mxaddict
left a comment
mxaddict
left a comment
There was a problem hiding this comment.
testedACK, changes make sense, and I tested a wallet built with this PR and performed as expected.
Contributor
|
tested Scenarios:
|
chasingkirkjufell
approved these changes
Nov 13, 2019
Contributor
chasingkirkjufell
left a comment
chasingkirkjufell
left a comment
There was a problem hiding this comment.
tested on 18.04
Scenarios:
mainnet node
Could not create via GUI
Could not create via CLI / Debug Console
devnet node
Could create via GUI
Could create via CL I/ Debug Console
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Dec 5, 2019
* disable cfund client functionality * enable vote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request disables on the client the creation of proposals and payment requests in mainnet. Other networks or network validation are not affected.
Disabled RPC commands:
createpaymentrequestcreateproposalDisabled GUI functionality:
Proposal creationPayment Request creation