Only count stakes in main chain#636
Merged
Merged
Conversation
aguycalled
requested review from
chasingkirkjufell,
mxaddict and
proletesseract
Contributor
|
@aguycalled I added a new scenario to the |
mxaddict
approved these changes
Nov 20, 2019
|
A new build of 0fe4ec2 has completed succesfully! |
|
A new build of dd1e801 has completed succesfully! |
chasingkirkjufell
approved these changes
Nov 20, 2019
Contributor
chasingkirkjufell
left a comment
chasingkirkjufell
left a comment
There was a problem hiding this comment.
Confirmed staking report is correct after re-org/orphan.
|
Looks good. Stake counters are correct. Thanks guys. |
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Nov 21, 2019
* Only count stakes in main chain * Fixed a function call * Updated the test to include the scenario for navcoin#636
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Nov 21, 2019
* Only count stakes in main chain * Fixed a function call * Updated the test to include the scenario for navcoin#636
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Dec 5, 2019
* Only count stakes in main chain * Fixed a function call * Updated the test to include the scenario for navcoin#636
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the count of stakes in the Staking tab of the GUI and the
getstakereportRPC command.What to test
Stake count still shows the correct number even if there are orphans or blocks are invalidated.