Fixed freezing GUI on reindex#638
Merged
Merged
Conversation
mxaddict
requested review from
aguycalled,
chasingkirkjufell and
proletesseract
mxaddict
force-pushed
the
freezing-gui-on-reindex
branch
from
d776e31 to
9634f5e
Compare
mxaddict
force-pushed
the
freezing-gui-on-reindex
branch
from
9634f5e to
aa64166
Compare
|
A new build of d776e31 has completed succesfully! |
|
A new build of aa64166 has completed succesfully! |
Member
|
tested gitian build osx |
aguycalled
approved these changes
Nov 23, 2019
chasingkirkjufell
approved these changes
Nov 25, 2019
Contributor
chasingkirkjufell
left a comment
chasingkirkjufell
left a comment
There was a problem hiding this comment.
confirmed fix with gitian build on windows 10
aguycalled
pushed a commit
to aguycalled/navcoin-core
that referenced
this pull request
Dec 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Looks like the freezing GUI when reindexing was caused by a change I ported from upstream BTC repo
Link: https://github.com/bitcoin/bitcoin/blob/v0.19.0.1/src/qt/clientmodel.cpp#L246
This PR fixes the freezing GUI on reindex
Test
-reindex=1