Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra stats to getblock #641

Merged
merged 2 commits into from
Dec 12, 2019
Merged

Add extra stats to getblock #641

merged 2 commits into from
Dec 12, 2019

Conversation

aguycalled
Copy link
Member

This pull request adds a few extra fields in the output of getblock

  • tx_count count of transactions of the block
  • proposal_count count of proposals created in the block
  • payment_request_count count of payment requests created in the block
  • proposal_votes_count count of votes for proposals in the block
  • payment_request_votes_count count of votes for payment requests in the block
  • payment_request_payouts_count count of payouts from payment requests in the block

What to test

  • The new fields of getblock <blockhash> must show the right values.

@navbuilder
Copy link

A new build of 74fb1c5 has completed succesfully!
Binaries available at https://build.nav.community/binaries/aguycalled-patch-4

Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested gitian build on window 10 64 bit and worked as expected

scenarios:

created txs & proposals, voted on proposals, cancels votes, created payment requests, got payouts.

all counts were correct

@proletesseract proletesseract merged commit 494d4e2 into master Dec 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants