Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RPC] Fix listconsultations "" #690

Merged
merged 1 commit into from Jun 4, 2020
Merged

[RPC] Fix listconsultations "" #690

merged 1 commit into from Jun 4, 2020

Conversation

aguycalled
Copy link
Member

This PR fixes the output of the rpc command listconsultations "" which was returning empty before but should return the full list of consultations.

@navbuilder
Copy link

A new build of 640dbb9 has completed succesfully!
Binaries available at https://build.nav.community/binaries/aguycalled-patch-6

chasingkirkjufell
chasingkirkjufell approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm issue on master and fix with this PR.

@mxaddict
Copy link
Contributor

mxaddict commented Jun 4, 2020

Tested on Ubuntu 18.04

@mxaddict mxaddict merged commit 4169273 into master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxaddict mxaddict mxaddict approved these changes

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

@dantudor dantudor Awaiting requested review from dantudor

@proletesseract proletesseract Awaiting requested review from proletesseract

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aguycalled @navbuilder @mxaddict @chasingkirkjufell