Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Transaction amount in popup window incorrect #773

Merged
merged 2 commits into from Feb 1, 2021
Merged

[FIX] Transaction amount in popup window incorrect #773

merged 2 commits into from Feb 1, 2021

Conversation

aguycalled
Copy link
Member

Fixes #768.

@chasingkirkjufell
Copy link
Contributor

away from my linux node atm, will test gitian

@mxaddict mxaddict self-requested a review January 31, 2021 19:47
mxaddict
mxaddict approved these changes Jan 31, 2021
View reviewed changes
Copy link
Contributor

@mxaddict mxaddict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

Looks good.

@navbuilder
Copy link

A new build of 65eb7b7 has completed succesfully!
Binaries available at https://build.nav.community/binaries/fix-subtract-fee

chasingkirkjufell
chasingkirkjufell approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed fix with gitian build on windows 10

@aguycalled aguycalled merged commit cb5e477 into navcoin:master Feb 1, 2021
@aguycalled aguycalled deleted the fix-subtract-fee branch February 1, 2021 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxaddict mxaddict mxaddict approved these changes

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

@dantudor dantudor Awaiting requested review from dantudor

@proletesseract proletesseract Awaiting requested review from proletesseract

@0x2830 0x2830 Awaiting requested review from 0x2830

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transaction amount in popup window incorrect
4 participants
@aguycalled @chasingkirkjufell @navbuilder @mxaddict