Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add nft index #936

Merged
merged 61 commits into from
Mar 9, 2022
Merged

Add nft index #936

merged 61 commits into from
Mar 9, 2022

Conversation

mxaddict
Copy link
Contributor

@mxaddict mxaddict commented Feb 14, 2022 •
edited
Loading

closes #919
closes #920

@navbuilder
Copy link

A new build of 3fe3737 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

1 similar comment
@navbuilder
Copy link

A new build of 3fe3737 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@mxaddict
Updated ALLINDEX
7f62acf
@mxaddict
Updated some whitespace in rpcwallet
152b3de
@mxaddict
Added nftindex flags to blocktree logic
b4be813
@mxaddict
Added txdb functions for nft index
5e21f53
@mxaddict
Added nft index update calls to Connect/Disconnect block
ee4040b
@mxaddict
Added nftunspendindex.h
5905863
@mxaddict
Added nftunspendindex.h
29deaf7
@mxaddict
Updates based on alex's input
b9cc1c2
@mxaddict
Added new DB_NFTUNSPENTINDEX char to txdb.h
10804bb
@mxaddict
Fixed some references
af6f3d8
@mxaddict
Moved a line down that I think should not be on the end of the previo…
a1a4a12 
…us line
@mxaddict
Removed tokenId from CNftUnspendIndexValue
e08a92f
@mxaddict
Updated nftunspentindex to serialize the blockHeight as big indian
e767a3f
@mxaddict
Changed blockHeight to uint32_t
e334121
@mxaddict
Updated nftunspentindex calls to not have the tokenId in value param
6415376
@mxaddict
Added a Read func for nftunspentindex
09af9b6
@mxaddict
Removed tokenId from CNftUnspentIndexValue
c517ba4
@mxaddict
Ops
ce50c30
@mxaddict
Added -ntfindex=1 to stressor for tokens
5d20e20
@mxaddict
Revert "Ops"
65d27f3 
This reverts commit ce50c30.
@mxaddict
Revert "Removed tokenId from CNftUnspentIndexValue"
b3d81e4 
This reverts commit c517ba4.
@mxaddict
Added UTXO data to listtokens
60a7c1f
@mxaddict
Copy link
Contributor Author

image

@aguycalled
Copy link
Member

image

Invalidating a block does not return to the previous utxo

@mxaddict
Copy link
Contributor Author

mxaddict commented Mar 2, 2022

@aguycalled I'm checking on this now

@mxaddict
Copy link
Contributor Author

mxaddict commented Mar 2, 2022

Does invalidate block run DisconnectBlock?

@mxaddict
Copy link
Contributor Author

mxaddict commented Mar 2, 2022

@aguycalled what did you mean by this:

the daemon does not check for discrepancies between -nftindex and the local db state (for example, if the local db has a nft index but -nftindex=0 was specified)

@navbuilder
Copy link

A new build of 3183371 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@navbuilder
Copy link

A new build of 7681f54 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@navbuilder
Copy link

A new build of cc4634c has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@navbuilder
Copy link

A new build of 7c18569 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@navbuilder
Copy link

A new build of 32f1884 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@navbuilder
Copy link

A new build of 3bcfbb5 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@navbuilder
Copy link

A new build of 9dbbf58 has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@navbuilder
Copy link

A new build of 6e1f7ed has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

@navbuilder
Copy link

A new build of bb1adde has completed succesfully!
Binaries available at https://build.nav.community/binaries/mxaddict:add-nft-index

chasingkirkjufell
chasingkirkjufell approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@chasingkirkjufell chasingkirkjufell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. thanks for cleaning up the stressor. you added the checks i wanted to add as well! sorry for the delays.

@mxaddict mxaddict merged commit c11dedd into navcoin:master Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aguycalled aguycalled aguycalled approved these changes

@chasingkirkjufell chasingkirkjufell chasingkirkjufell approved these changes

@0x2830 0x2830 Awaiting requested review from 0x2830

@sakdeniz sakdeniz Awaiting requested review from sakdeniz

Assignees
No one assigned
Labels
ready for review waiting for build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show last UTXO of an NFT through RPC command Implement an index which tracks the last UTXO of each NFT
4 participants
@mxaddict @navbuilder @chasingkirkjufell @aguycalled