-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
인터페이스 구현체의 interface 지정 이슈 #23
Comments
ExtendedBTreeGetOperationImpl도 interface 지정이 잘못 되어 있는 것 같습니다..
|
ExtendedBTreeGetOperationImple 의 instance 를 ArcusClient class 에서 생성하는데 이때 매개변수로 넘겨주는 Callback interface 의 구현을 부분을 보면 private <T> CollectionFuture<Map<ByteArrayBKey, Element<T>>> asyncBopExtendedGet(
final String k, final CollectionGet<T> collectionGet,
final boolean reverse, final Transcoder<T> tc) {
...
Operation op = opFact.collectionGet2(k, collectionGet,
new ExtendedBTreeGetOperation.Callback() {
TreeMap<ByteArrayBKey, Element<T>> map = new ByteArrayTreeMap<ByteArrayBKey, Element<T>>(
(reverse) ? Collections.reverseOrder() : null);
...
public void gotData(String key, byte[] subkey,
byte[] elementFlag, int flags, byte[] data) {
assert key.equals(k) : "Wrong key returned";
Element<T> element = new Element<T>(subkey, tc
.decode(new CachedData(flags, data, tc
.getMaxSize())), elementFlag);
map.put(new ByteArrayBKey(subkey), element);
}
}); |
commit 완료 했습니다. |
code reveiw & merge 했습니다.. |
CLEANUP: send command in ZookeeperFourLetterAsyncComponent
CollectionUpsertOperationImpl의 interface 지정이 아래와 같습니다.
CollectionUpsertOperation interface를 지정하도록 수정하는 게 좋을 것 같습니다.
참고 사항으로, CollectionStoreOperation와 CollectionUpsertOperation가 동일한 interface이기 때문에,
동작에는 문제가 없습니다.
The text was updated successfully, but these errors were encountered: