Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FEAT: Add check DNS cache ttl method. #731

Merged
merged 1 commit into from
Jun 11, 2024
Merged

FEAT: Add check DNS cache ttl method. #731

merged 1 commit into from
Jun 11, 2024

Conversation

brido4125
Copy link
Collaborator

@brido4125 brido4125 commented Mar 15, 2024 •
edited
Loading

관련 이슈

https://github.com/jam2in/arcus-works/issues/487

변경된 구현

DNS cache TTL 값을 확인하는 법

  1. Security.getProperty(...) -> "networkaddress.cache.ttl" 프로퍼티 사용
  2. System.getProperty(...) -> "sun.net.inetaddr.ttl" 프로퍼티 사용
  3. CacheManger객체 사용 여부 확인

Invalid 기준

  • 가져온 DnsCacheTtl 값이 0 < ttl or ttl > 300 면 invalid 판정

ArcusClient 생성 시 DNS 검증 여부

default 값을 true로 설정해서 ArcusClient 인스턴스가 생성될 때매다
기본적으로 검증하도록 구현했습니다.

ArcusClientPool을 사용하더라도 getInstance를 통해
본 PR에서 변경된 ArcusClient 생성자를 호출합니다.

@brido4125 brido4125 self-assigned this Mar 15, 2024
@brido4125 brido4125 requested a review from uhm0311 March 15, 2024 07:10
uhm0311
uhm0311 requested changes Mar 15, 2024
View reviewed changes
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ConnectionFactoryBuilder.java Outdated Show resolved Hide resolved
uhm0311
uhm0311 requested changes Mar 18, 2024
View reviewed changes
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
uhm0311
uhm0311 requested changes Mar 20, 2024
View reviewed changes
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
uhm0311
uhm0311 requested changes Mar 21, 2024
View reviewed changes
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
uhm0311
uhm0311 requested changes Mar 21, 2024
View reviewed changes
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
@brido4125 brido4125 force-pushed the feat/dnsTtl branch 2 times, most recently from 2b8d6c5 to 7f0063d Compare March 22, 2024 01:08
uhm0311
uhm0311 previously approved these changes Mar 22, 2024
View reviewed changes
@jhpark816
Copy link
Collaborator

@brido4125
DNS cache TTL 설정을 어떻게 확인하고 어떤 설정이면 invalid한 것인지
구현 설명을 PR 코멘트에 추가 바랍니다.

jhpark816
jhpark816 reviewed Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

pom.xml Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
@brido4125 brido4125 force-pushed the feat/dnsTtl branch 2 times, most recently from 2e68905 to 2ed716a Compare March 29, 2024 00:48
@brido4125 brido4125 marked this pull request as draft March 29, 2024 01:02
@brido4125 brido4125 marked this pull request as ready for review March 29, 2024 01:29
jhpark816
jhpark816 reviewed Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
@uhm0311 uhm0311 force-pushed the develop branch 2 times, most recently from 07918e6 to ae2a82f Compare April 2, 2024 07:53
jhpark816
jhpark816 reviewed Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

src/main/java/net/spy/memcached/ArcusClient.java Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
uhm0311
uhm0311 requested changes May 31, 2024
View reviewed changes
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
uhm0311
uhm0311 requested changes May 31, 2024
View reviewed changes
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
uhm0311
uhm0311 previously approved these changes May 31, 2024
View reviewed changes
@brido4125 brido4125 requested a review from oliviarla June 3, 2024 00:06
oliviarla
oliviarla previously approved these changes Jun 5, 2024
View reviewed changes
@uhm0311 uhm0311 self-requested a review June 5, 2024 08:08
uhm0311
uhm0311 previously approved these changes Jun 5, 2024
View reviewed changes
jhpark816
jhpark816 reviewed Jun 5, 2024
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

src/main/java/net/spy/memcached/ArcusClient.java Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Outdated Show resolved Hide resolved
@brido4125 brido4125 dismissed stale reviews from uhm0311 and oliviarla via 488bcdf June 10, 2024 01:53
jhpark816
jhpark816 reviewed Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 완료

src/main/java/net/spy/memcached/ArcusClient.java Show resolved Hide resolved
src/main/java/net/spy/memcached/ArcusClient.java Show resolved Hide resolved
@jhpark816 jhpark816 merged commit cf4ae24 into naver:develop Jun 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpark816 jhpark816 jhpark816 left review comments

@uhm0311 uhm0311 uhm0311 approved these changes

@oliviarla oliviarla oliviarla approved these changes

Assignees

@brido4125 brido4125

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brido4125 @jhpark816 @uhm0311 @oliviarla