Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST: Add ArcusClient naming test to CI. #761

Merged
merged 1 commit into from
May 29, 2024

Conversation

uhm0311
Copy link
Collaborator

@uhm0311 uhm0311 commented May 29, 2024

#738

  • 위 PR에서 반영되지 않았던 CI 테스트 설정을 수정했습니다.
  • 테스트 코드 통과를 위해 ArcusClient의 기본 네이밍 방식에 있던 버그를 수정했습니다.
  • ArcusClient 객체가 여러번 생성되었어도 테스트 코드가 통과하도록 정확한 CLIENT_ID 값이 아닌 정규식을 사용하도록 했습니다.

@uhm0311 uhm0311 requested a review from jhpark816 May 29, 2024 06:40
@jhpark816
Copy link
Collaborator

@brido4125
수정된 사항을 확인하세요.

@jhpark816 jhpark816 merged commit d50edf1 into naver:develop May 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants