INTERNAL: Remove unused boolean field dead in ArcusClient. #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
https://github.com/jam2in/arcus-works/issues/572
변경 사항
ArcusClient 내의 private으로 설정된 dead 필드의 경우
shutdown() 호출되면 true로 변경된다.
하지만 ArcusClient 클래스 내에서는 어떠한 로직에서 사용되지 않고,
getter가 없어 다른 클래스에서의 접근도 불가하다.
또한 테스트 코드에서 리플렉션을 통해 사용되지도 않는다.
그래서 사용되지 않는 필드을 제거한다.