REFACTOR: ArucsClientPool constructor parameters. #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brido4125
force-pushed
the
internal/ArcusClientPoolConstructor
branch
from
2ec8a20
to
02b0831
Compare
brido4125
changed the title
uhm0311
requested changes
Jun 5, 2024
brido4125
force-pushed
the
internal/ArcusClientPoolConstructor
branch
from
02b0831
to
50f632e
Compare
uhm0311
approved these changes
Jun 10, 2024
jhpark816
reviewed
Jun 10, 2024
| public ArcusClientPool(CacheManager cacheManager) { | ||
| this.client = cacheManager.getAC(); | ||
| this.poolSize = client.length; | ||
| this.rand = new Random(); |
There was a problem hiding this comment.
ArcusClientPool 생성자에서 cacheManager를 인자로 받는 의도는 무엇인가요?
아래의 clientPool 인자만 가져도 충분하지 않나 생각됩니다.
public ArcusClientPool(ArcusClient[] clientPool)There was a problem hiding this comment.
본 PR의 이슈와 관련 있습니다.
간단히 설명하자면, CacheManager나 Locator 등의 Pool에서 사용되는 객체들에 대한 의존성을
ArcusClientPool에 위임하고 ArcusClient와의 결합을 끊어내려고 합니다.
이슈 설명 한번 읽어주세요.
|
@oliviarla 추가 리뷰어 지정합니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈
https://github.com/jam2in/arcus-works/issues/572
구현
ArcusClientPool 의 생성자를 리팩토링하였습니다.
기존 코드와 동일하게 CacheManager 생성자가 완료되면,
zk로부터 캐시리스트 정보를 받아옴이 보장됩니다.
그러므로 cacheManager.getAC()가 정확한 정보를 가지게 됩니다.