FEAT: Change ArcusClient mbean name more readable. #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uhm0311
reviewed
Jun 13, 2024
uhm0311
requested changes
Jun 13, 2024
| mbean.getClass().getPackage().getName() + ":type=" | ||
| + mbean.getClass().getSimpleName() + "-" | ||
| + mbean.hashCode()); | ||
|
|
brido4125
force-pushed
the
feat/mBeanName
branch
from
89f379b
to
6ea7bd2
Compare
uhm0311
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
https://github.com/jam2in/arcus-works/issues/490
변경 내용
기존에 아래와 같은 포맷으로 수집되던 메트릭입니다.
이를 아래와 같이 변경하는 PR입니다.
일반화 시키면 아래와 같이 구성됩니다.
이슈의 코멘트도 참고부탁드립니다.
https://github.com/jam2in/arcus-works/issues/490#issuecomment-2164178885